Review main Merged

60611[FEATURE] Send plaintext and HTML multipart mails

Mathias Brodala CR +2 V +2 Hard +255 −85 updated 04/28/19, 15:10

Commit message

Now by default, mails sent with the EmailFinisher contain both a
plaintext and an HTML part. The latter can be controlled with the
new "addHtmlPart" option which is enabled by default.

The former "format" option is removed from the backend UI and
migrated to the new "addHtmlPart" option.

Review

  • Code review CR +2 Done
    • Ralf Zimmermann +2
    • Susi Moog +1
  • Verified V +2 Done
    • Ralf Zimmermann +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 12

Review log 2232

Show 57 earlier messages
  1. Mathias Brodala uploaded patch set 1 04/28/19, 10:54

  2. Mathias Brodala uploaded patch set 2 04/28/19, 10:59

  3. TYPO3com voted on patch set 1 V +1 04/28/19, 11:08 Completed build in 14m 42s on Sun, 28 Apr, 01:08 PM Test Summary: 47464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33611

  4. TYPO3com voted on patch set 2 V +1 04/28/19, 11:11 Completed build in 11m 35s on Sun, 28 Apr, 01:11 PM Test Summary: 47464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33612

  5. Mathias Brodala uploaded patch set 3 04/28/19, 11:15

  6. Mathias Brodala updated the commit message in patch set 4 04/28/19, 11:16

  7. Mathias Brodala commented on patch set 4 04/28/19, 11:16

    Switched logic to have a "addHtmlPart" option which is enabled by default. If disabled, only a plaintext part is added to mails.
  1. TYPO3com voted on patch set 3 V +1 04/28/19, 11:29 Completed build in 13m 26s on Sun, 28 Apr, 01:29 PM Test Summary: 47464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33613

  2. TYPO3com voted on patch set 4 V +1 04/28/19, 11:29 Completed build in 13m 39s on Sun, 28 Apr, 01:29 PM Test Summary: 47464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33614

  3. Björn Jacob commented on patch set 5 04/28/19, 12:00

    Published edit on patch set 4.
  4. TYPO3com voted on patch set 5 V +1 04/28/19, 12:16 Completed build in 15m 28s on Sun, 28 Apr, 02:16 PM Test Summary: 47464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33615

  5. Susi Moog commented on patch set 5 V -1 04/28/19, 12:29

    now sends plaintext templates as html - will fix.
  6. Susi Moog uploaded patch set 6 04/28/19, 12:31

  7. Dominik Merkel voted on patch set 6 V +1 04/28/19, 12:42

  8. TYPO3com voted on patch set 6 V +1 04/28/19, 12:48 Completed build in 16m 58s on Sun, 28 Apr, 02:48 PM Test Summary: 47464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33618

  9. Mathias Brodala commented on patch set 6 CR -1 04/28/19, 13:22

    EmailFinisher.php:240 Unresolved

    Here we need a deprecation notice.
  10. Ralf Zimmermann uploaded patch set 7 04/28/19, 13:46

  11. Ralf Zimmermann commented on patch set 7 CR -1 04/28/19, 13:46

    we need a deprecation notice
  12. Ralf Zimmermann uploaded patch set 8 04/28/19, 13:49

  13. Susi Moog uploaded patch set 9 04/28/19, 13:51

  14. Ralf Zimmermann uploaded patch set 10 04/28/19, 13:53

  15. Björn Jacob commented on patch set 10 04/28/19, 14:00

    EmailFinisher.php:76

    "Flexform overrides write"
  16. Ralf Zimmermann commented on patch set 11 04/28/19, 14:03

    Published edit on patch set 10.
  17. Ralf Zimmermann commented on patch set 11 04/28/19, 14:03

    EmailFinisher.php:76 Reply

    Done
  18. TYPO3com voted on patch set 7 V +1 04/28/19, 14:07 Completed build in 21m 29s on Sun, 28 Apr, 04:07 PM Test Summary: 47464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33628

  19. TYPO3com voted on patch set 10 V -1 04/28/19, 14:20 Completed build in 18m 13s on Sun, 28 Apr, 04:20 PM Test Summary: 247 of 42454 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33632

  20. Ralf Zimmermann uploaded patch set 12 04/28/19, 14:32

  21. TYPO3com voted on patch set 11 V +1 04/28/19, 14:32 Completed build in 15m 00s on Sun, 28 Apr, 04:32 PM Test Summary: 47464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33633

  22. TYPO3com voted on patch set 12 V +1 04/28/19, 14:55 Completed build in 19m 13s on Sun, 28 Apr, 04:55 PM Test Summary: 47460 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33637

  23. Susi Moog voted on patch set 12 V +1 CR +1 04/28/19, 15:10

  24. Ralf Zimmermann voted on patch set 12 V +2 CR +2 04/28/19, 15:10

  25. Ralf Zimmermann merged patch set 13 04/28/19, 15:10