Review main Abandoned

60615[BUGFIX] Restore Inspector-PropertyGridEditor warning message

Ralf Zimmermann CR 0 V 0 Easy +33 −12 updated 11/21/19, 10:14

Commit message

Restore the warning flash message if the user want to delete the last
item within a "Inspector-PropertyGridEditor" inspector editor
(lost with ##80420) but only show the warning flash message if the
inspector editor has a "NotEmpty" validator applied.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 56

  1. Ralf Zimmermann uploaded patch set 1 04/28/19, 19:22

  2. TYPO3com voted on patch set 1 V +1 04/28/19, 19:36 Completed build in 14m 05s on Sun, 28 Apr, 09:36 PM Test Summary: 47460 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33645

  3. Mathias Brodala commented on patch set 1 04/29/19, 07:29

    I intentionally removed this to simplify the code and make this editor behavior consistent with all other editors. Other editors also don't prevent you from entering an invalid state (empty field).
  4. Björn Jacob commented on patch set 1 CR -1 05/03/19, 06:04

    Mathias concerns should be discussed. I strongly support having a consistent behaviour.
  5. Susi Moog abandoned the change 11/21/19, 10:13

    abandoned on request
  6. Mathias Brodala commented on patch set 1 11/21/19, 10:14

    As discussed: the property grid editor already properly marks the whole field as "required" as long as no item was added. Saving the form is impossible in this case. This was verified once more with recipients of the mail finisher and items of a multi-select form element.