Review main Merged

60616[BUGFIX] Write "PropertyGridEditor" default values as integer number

Ralf Zimmermann CR +2 V +2 Easy +35 −14 updated 11/24/19, 11:23

Commit message

Write default values which are written through
"Inspector-PropertyGridEditor" inspector editors (form editor) as
integer numbers if the values can be interpreted as integer numbers.

Review

  • Code review CR +2 Done
    • Ralf Zimmermann +2
    • Björn Jacob +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Ralf Zimmermann +2
    • Björn Jacob +1
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2839

Show 1014 earlier messages
  1. Ralf Zimmermann uploaded patch set 1 04/28/19, 20:16

  2. TYPO3com voted on patch set 1 V +1 04/28/19, 20:29 Completed build in 13m 00s on Sun, 28 Apr, 10:29 PM Test Summary: 47460 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33646

  3. Mathias Brodala commented on patch set 1 04/29/19, 07:27

    InspectorComponent.js:498 Unresolved

    I'd recommend replicating the logic from MathUtility::canBeInterpretedAsInteger() here, thus compare string representation of the value with a stringified integer prepresentation of the value. Also yoda conditions we don't use. ;-)
  4. Björn Jacob commented on patch set 1 CR -1 05/03/19, 06:03

    Mathias concerns should be discussed :)
  5. Mathias Brodala uploaded patch set 2 11/21/19, 14:22

  6. Mathias Brodala voted on patch set 2 V +1 CR +1 11/21/19, 14:22

  7. TYPO3com voted on patch set 2 V +1 11/21/19, 14:29 Completed build in 07m 10s on Thu, 21 Nov, 02:29 PM Test Summary: 48061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38554

  8. Andreas Kienast commented on patch set 2 CR -1 11/22/19, 14:14

    Core.js:167

    why not `typeof value === 'object'` instead?

    Core.js:171

    This fails if value is a real float. I think you forgot a `toString()` here.

    InspectorComponent.js:519

    parseInt(value, 10);
  9. Ralf Zimmermann commented on patch set 3 11/22/19, 14:37

    Published edit on patch set 2.
  10. Ralf Zimmermann commented on patch set 3 11/22/19, 14:38

    Core.js:167 Reply

    Done

    Core.js:171 Reply

    Done

    InspectorComponent.js:519 Reply

    Done
  11. Ralf Zimmermann commented on patch set 4 11/22/19, 14:39

    Published edit on patch set 3.
  12. TYPO3com voted on patch set 3 V +1 11/22/19, 14:45 Completed build in 07m 46s on Fri, 22 Nov, 02:45 PM Test Summary: 48085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38645

  13. TYPO3com voted on patch set 4 V +1 11/22/19, 14:46 Completed build in 07m 08s on Fri, 22 Nov, 02:46 PM Test Summary: 48085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38646

  14. Mathias Brodala commented on patch set 4 CR -1 11/22/19, 14:54

    Core.js:167

    If we use the native typeof, we should do so everywhere here. Otherwise we should stay in line with the existing code.
  1. Andreas Kienast commented on patch set 4 11/22/19, 15:17

    Core.js:167 Reply

    Fun fact: we can drop this condition completely since `typeof []` evaluates to `object` as well
  2. Ralf Zimmermann commented on patch set 5 11/22/19, 15:20

    Published edit on patch set 4.
  3. Ralf Zimmermann commented on patch set 5 11/22/19, 15:22

    Core.js:167 Reply Unresolved

    Iam with Mathias. We should change such things within a seperate patch. Otherwise this patch explodes :)
  4. TYPO3com voted on patch set 5 V +1 11/22/19, 15:28 Completed build in 07m 28s on Fri, 22 Nov, 03:28 PM Test Summary: 48085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38651

  5. Mathias Brodala voted on patch set 5 V +1 CR +1 11/22/19, 17:28

  6. Susi Moog commented on patch set 5 CR -1 11/22/19, 17:48

    Core.js:166

    please use Number.isInteger in master (no IE support but otherwise fine)
  7. Ralf Zimmermann commented on patch set 6 11/22/19, 18:34

    Published edit on patch set 5.
  8. Mathias Brodala commented on patch set 6 V -1 11/22/19, 18:40

    InspectorComponent.js:518

    This returns false for "1" and similar.
  9. TYPO3com voted on patch set 6 V +1 11/22/19, 18:42 Completed build in 07m 31s on Fri, 22 Nov, 06:42 PM Test Summary: 48104 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38688

  10. Ralf Zimmermann uploaded patch set 7 11/22/19, 18:44

  11. Ralf Zimmermann commented on patch set 7 11/22/19, 18:49

    Core.js:166 Reply Unresolved

    Nope, we need something like "canBeInterpretedAsInteger". Number.isInteger() can not handle strings.

    InspectorComponent.js:518 Reply

    Ack
  12. TYPO3com voted on patch set 7 V +1 11/22/19, 18:51 Completed build in 07m 19s on Fri, 22 Nov, 06:51 PM Test Summary: 48104 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38690

  13. Mathias Brodala voted on patch set 7 V +1 CR +1 11/22/19, 19:07

  14. Ralf Zimmermann commented on patch set 8 11/23/19, 14:11

    Published edit on patch set 7.
  15. TYPO3com voted on patch set 8 V -1 11/23/19, 14:19 Completed build in 07m 10s on Sat, 23 Nov, 02:19 PM Test Summary: 48170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38750

  16. Ralf Zimmermann commented on patch set 9 11/23/19, 14:26

    Published edit on patch set 8.
  17. TYPO3com voted on patch set 9 V +1 11/23/19, 14:36 Completed build in 09m 16s on Sat, 23 Nov, 02:36 PM Test Summary: 48181 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38754

  18. Björn Jacob commented on patch set 9 V -1 11/23/19, 15:05

    Even with the applied patch, the .form.yaml definition contains defaultValue: '1' as string and not as integer. The "Selected" checkbox is not properly handled.
  19. Ralf Zimmermann uploaded patch set 10 11/24/19, 09:30

  20. TYPO3com voted on patch set 10 V -1 11/24/19, 09:37 Completed build in 07m 09s on Sun, 24 Nov, 09:37 AM Test Summary: 48160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38792

  21. TYPO3com voted on patch set 10 V +1 11/24/19, 09:53 Completed build in 30m 36s on Sun, 24 Nov, 09:53 AM Test Summary: 48161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38792

  22. Björn Jacob voted on patch set 10 V +1 CR +1 11/24/19, 10:15

  23. Mathias Brodala voted on patch set 10 V +1 CR +1 11/24/19, 11:22

  24. Ralf Zimmermann voted on patch set 10 V +2 CR +2 11/24/19, 11:23

  25. Ralf Zimmermann merged patch set 11 11/24/19, 11:23