60617[BUGFIX] Make FileUpload and ImageUpload mimetype validation more strict
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Björn Jacob +1
- Mathias Brodala +1
-
Verified V +2 Done
- Benni Mack +2
- Björn Jacob +1
- Mathias Brodala +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −0
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml4+3 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-88238-AllowedMimeTypesOfFileUploadAndImageUpload.rstnew+97 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-88238-FeatureToggleFormlegacyUploadMimeTypes.rstnew+22 −0
- typo3/sysext/form/Configuration/Yaml/BaseSetup.yaml+21 −2
Review log 2227
Show 12 earlier messages
-
Ralf Zimmermann uploaded patch set 1 04/28/19, 21:01
-
TYPO3com voted on patch set 1 V +1 04/28/19, 21:12 Completed build in 10m 41s on Sun, 28 Apr, 11:12 PM Test Summary: 47460 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33647
-
Oliver Klee commented on patch set 1 04/28/19, 21:25
As this improves security, can/should we have this for older branches as well? -
Björn Jacob voted on patch set 1 CR +1 05/03/19, 05:58
-
Frank Nägler commented on patch set 1 05/31/19, 11:07
I guess this is a breaking change, right? Existing forms will break without an update, This change of behavior should be marked as breaking, also is it possible to provide an upgrade wizard? -
Mathias Brodala commented on patch set 1 V -1 11/21/19, 12:56
This is in fact a breaking change. I'll see if I can hide this behind a feature flag. In any case this is then nothing for older releases. -
Mathias Brodala uploaded patch set 2 11/21/19, 13:13
-
TYPO3com voted on patch set 2 V +1 11/21/19, 13:23 Completed build in 10m 20s on Thu, 21 Nov, 01:23 PM Test Summary: 48061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38548
-
Mathias Brodala uploaded patch set 3 11/21/19, 13:34
-
Mathias Brodala voted on patch set 3 V +1 CR +1 11/21/19, 13:34
-
TYPO3com voted on patch set 3 V +1 11/21/19, 13:42 Completed build in 08m 33s on Thu, 21 Nov, 01:42 PM Test Summary: 48061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38550
-
Björn Jacob voted on patch set 3 V +1 CR +1 11/21/19, 14:22
-
Björn Jacob commented on patch set 3 11/21/19, 14:25
... on it -
Björn Jacob voted on patch set 3 V 0 CR 0 11/21/19, 14:25
-
Björn Jacob commented on patch set 4 11/21/19, 14:28
Published edit on patch set 3. -
Björn Jacob voted on patch set 4 V +1 CR +1 11/21/19, 14:28
-
TYPO3com voted on patch set 4 V +1 11/21/19, 14:37 Completed build in 08m 27s on Thu, 21 Nov, 02:37 PM Test Summary: 48061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38556
-
Mathias Brodala voted on patch set 4 V +1 CR +1 11/21/19, 14:38
-
Benni Mack commented on patch set 4 CR -1 11/21/19, 15:48
DefaultConfigurationDescription.yaml:210what are legacy mime types? Maybe you want to explain this here (for site admins) why they should enable it and when? -
Mathias Brodala commented on patch set 4 11/21/19, 15:55
DefaultConfigurationDescription.yaml:210ReplyYou are right, just from reading this the implication is unclear. How about this: > If on, some mime types are predefined for the "FileUpload" and "ImageUpload" elements of the "form" extension and cannot be removed. -
Benni Mack commented on patch set 4 11/21/19, 15:56
DefaultConfigurationDescription.yaml:210Replyyup. what are the implications? "Allowing people to always upload certain filetypes"? or sth like that? In general: YES! -
Mathias Brodala uploaded patch set 5 11/21/19, 16:01
-
Mathias Brodala commented on patch set 5 V +1 CR +1 11/21/19, 16:02
DefaultConfigurationDescription.yaml:210Reply UnresolvedI've updated a more specific text explaining the implication. -
Björn Jacob voted on patch set 5 V +1 CR +1 11/21/19, 16:07
-
TYPO3com voted on patch set 5 V +1 11/21/19, 16:08 Completed build in 07m 12s on Thu, 21 Nov, 04:08 PM Test Summary: 48085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38563
-
Benni Mack voted on patch set 5 V +2 CR +2 11/21/19, 19:36
-
Benni Mack merged patch set 6 11/21/19, 19:36