Review main Merged

60617[BUGFIX] Make FileUpload and ImageUpload mimetype validation more strict

Ralf Zimmermann CR +2 V +2 Normal +144 −2 updated 11/21/19, 19:36

Commit message

Only use the "allowedMimeTypes" property values from the form definition
for the mime type validation of an uploaded file.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Björn Jacob +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Benni Mack +2
    • Björn Jacob +1
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 2227

Show 12 earlier messages
  1. Ralf Zimmermann uploaded patch set 1 04/28/19, 21:01

  2. TYPO3com voted on patch set 1 V +1 04/28/19, 21:12 Completed build in 10m 41s on Sun, 28 Apr, 11:12 PM Test Summary: 47460 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33647

  1. Oliver Klee commented on patch set 1 04/28/19, 21:25

    As this improves security, can/should we have this for older branches as well?
  2. Björn Jacob voted on patch set 1 CR +1 05/03/19, 05:58

  3. Frank Nägler commented on patch set 1 05/31/19, 11:07

    I guess this is a breaking change, right? Existing forms will break without an update, This change of behavior should be marked as breaking, also is it possible to provide an upgrade wizard?
  4. Mathias Brodala commented on patch set 1 V -1 11/21/19, 12:56

    This is in fact a breaking change. I'll see if I can hide this behind a feature flag. In any case this is then nothing for older releases.
  5. Mathias Brodala uploaded patch set 2 11/21/19, 13:13

  6. TYPO3com voted on patch set 2 V +1 11/21/19, 13:23 Completed build in 10m 20s on Thu, 21 Nov, 01:23 PM Test Summary: 48061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38548

  7. Mathias Brodala uploaded patch set 3 11/21/19, 13:34

  8. Mathias Brodala voted on patch set 3 V +1 CR +1 11/21/19, 13:34

  9. TYPO3com voted on patch set 3 V +1 11/21/19, 13:42 Completed build in 08m 33s on Thu, 21 Nov, 01:42 PM Test Summary: 48061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38550

  10. Björn Jacob voted on patch set 3 V +1 CR +1 11/21/19, 14:22

  11. Björn Jacob commented on patch set 3 11/21/19, 14:25

    ... on it
  12. Björn Jacob voted on patch set 3 V 0 CR 0 11/21/19, 14:25

  13. Björn Jacob commented on patch set 4 11/21/19, 14:28

    Published edit on patch set 3.
  14. Björn Jacob voted on patch set 4 V +1 CR +1 11/21/19, 14:28

  15. TYPO3com voted on patch set 4 V +1 11/21/19, 14:37 Completed build in 08m 27s on Thu, 21 Nov, 02:37 PM Test Summary: 48061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38556

  16. Mathias Brodala voted on patch set 4 V +1 CR +1 11/21/19, 14:38

  17. Benni Mack commented on patch set 4 CR -1 11/21/19, 15:48

    DefaultConfigurationDescription.yaml:210

    what are legacy mime types? Maybe you want to explain this here (for site admins) why they should enable it and when?
  18. Mathias Brodala commented on patch set 4 11/21/19, 15:55

    DefaultConfigurationDescription.yaml:210 Reply

    You are right, just from reading this the implication is unclear. How about this: > If on, some mime types are predefined for the "FileUpload" and "ImageUpload" elements of the "form" extension and cannot be removed.
  19. Benni Mack commented on patch set 4 11/21/19, 15:56

    DefaultConfigurationDescription.yaml:210 Reply

    yup. what are the implications? "Allowing people to always upload certain filetypes"? or sth like that? In general: YES!
  20. Mathias Brodala uploaded patch set 5 11/21/19, 16:01

  21. Mathias Brodala commented on patch set 5 V +1 CR +1 11/21/19, 16:02

    DefaultConfigurationDescription.yaml:210 Reply Unresolved

    I've updated a more specific text explaining the implication.
  22. Björn Jacob voted on patch set 5 V +1 CR +1 11/21/19, 16:07

  23. TYPO3com voted on patch set 5 V +1 11/21/19, 16:08 Completed build in 07m 12s on Thu, 21 Nov, 04:08 PM Test Summary: 48085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38563

  24. Benni Mack voted on patch set 5 V +2 CR +2 11/21/19, 19:36

  25. Benni Mack merged patch set 6 11/21/19, 19:36