60627[BUGFIX] Do not open EditDocumentController in modal
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Markus Klein +1
-
Verified V +2 Done
- Susi Moog +2
- Joerg Kummer +1
- Guido Schmechel +1
- TYPO3com +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/PageActions.ts+3 −1
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+2 −14
- typo3/sysext/backend/Classes/View/PageLayoutView.php+5 −5
- typo3/sysext/backend/Resources/Public/JavaScript/PageActions.js+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+1 −1
Review log 1620
-
Andreas Kienast uploaded patch set 1 04/29/19, 20:33
-
TYPO3com voted on patch set 1 V +1 04/29/19, 20:50 Completed build in 17m 04s on Mon, 29 Apr, 10:50 PM Test Summary: 47468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33661
-
Stefan Froemken commented on patch set 1 04/30/19, 06:57
Much better now. Thank you. But when I click "close" or "save" I'm still in this PopUp window. Is this the expected behavior? -
Andreas Kienast commented on patch set 1 04/30/19, 07:12
> Patch Set 1: > > Much better now. Thank you. But when I click "close" or "save" I'm still in this PopUp window. Is this the expected behavior? For now yes. Otherwise we'd have to let the FormEngine close a modal window of its parent window which can't be achieved right now. -
Susi Moog commented on patch set 1 V -1 04/30/19, 08:15
when trying to do anything that requires another modal (for example adding an image from the file browser) it fails in modal context. -
Andreas Kienast commented on patch set 1 CR -1 04/30/19, 10:09
> Patch Set 1: Verified-1 > > when trying to do anything that requires another modal (for example adding an image from the file browser) it fails in modal context. I think I have a better solution up my sleeves. -
Andreas Kienast uploaded patch set 2 04/30/19, 11:46
-
TYPO3com voted on patch set 2 V +1 04/30/19, 12:00 Completed build in 13m 56s on Tue, 30 Apr, 02:00 PM Test Summary: 47472 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33669
-
Guido Schmechel voted on patch set 2 V +1 CR +1 05/04/19, 09:59
-
Joerg Kummer commented on patch set 2 V -1 05/04/19, 11:12
As sys-admin patch2 works in web-modul 'page'. The modal wizard is broken, when in web-modul 'list' clickin action icon for add content-element in top of the table-list 'page-content'. Does not matter if 'mod.web_layout.disableNewContentElementWizard=1' is set or not. -
Andreas Kienast uploaded patch set 3 05/04/19, 13:12
-
TYPO3com voted on patch set 3 V -1 05/04/19, 13:26 Completed build in 14m 03s on Sat, 4 May, 03:26 PM Test Summary: 47475 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33713
-
Andreas Kienast uploaded patch set 4 05/05/19, 11:00
-
TYPO3com voted on patch set 4 V +1 05/05/19, 11:12 Completed build in 11m 41s on Sun, 5 May, 01:12 PM Test Summary: 47475 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33714
-
Joerg Kummer commented on patch set 4 V +1 05/05/19, 12:34
Faboulus - various tests passed from my side. I'm not familiar with typescript - therfore no code review. -
Guido Schmechel voted on patch set 4 V +1 05/05/19, 18:19
-
Susi Moog voted on patch set 4 V +1 CR +1 05/05/19, 18:54
-
Markus Klein voted on patch set 4 CR +1 05/05/19, 20:33
-
Susi Moog voted on patch set 4 V +2 CR +2 05/06/19, 04:58
-
Susi Moog merged patch set 5 05/06/19, 04:58