Review main Merged

60627[BUGFIX] Do not open EditDocumentController in modal

Andreas Kienast CR +2 V +2 Easy +12 −22 updated 05/06/19, 04:58

Commit message

If `mod.web_layout.disableNewContentElementWizard=1` is set, the
"New Content Element" wizard is skipped and EditDocumentController's
FormEngine is called directly.

In that case, the modal must not get opened as this doesn't work in
combination with FormEngine.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Markus Klein +1
  • Verified V +2 Done
    • Susi Moog +2
    • Joerg Kummer +1
    • Guido Schmechel +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1620

  1. Andreas Kienast uploaded patch set 1 04/29/19, 20:33

  2. TYPO3com voted on patch set 1 V +1 04/29/19, 20:50 Completed build in 17m 04s on Mon, 29 Apr, 10:50 PM Test Summary: 47468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33661

  3. Stefan Froemken commented on patch set 1 04/30/19, 06:57

    Much better now. Thank you. But when I click "close" or "save" I'm still in this PopUp window. Is this the expected behavior?
  4. Andreas Kienast commented on patch set 1 04/30/19, 07:12

    > Patch Set 1: > > Much better now. Thank you. But when I click "close" or "save" I'm still in this PopUp window. Is this the expected behavior? For now yes. Otherwise we'd have to let the FormEngine close a modal window of its parent window which can't be achieved right now.
  5. Susi Moog commented on patch set 1 V -1 04/30/19, 08:15

    when trying to do anything that requires another modal (for example adding an image from the file browser) it fails in modal context.
  6. Andreas Kienast commented on patch set 1 CR -1 04/30/19, 10:09

    > Patch Set 1: Verified-1 > > when trying to do anything that requires another modal (for example adding an image from the file browser) it fails in modal context. I think I have a better solution up my sleeves.
  7. Andreas Kienast uploaded patch set 2 04/30/19, 11:46

  8. TYPO3com voted on patch set 2 V +1 04/30/19, 12:00 Completed build in 13m 56s on Tue, 30 Apr, 02:00 PM Test Summary: 47472 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33669

  9. Guido Schmechel voted on patch set 2 V +1 CR +1 05/04/19, 09:59

  10. Joerg Kummer commented on patch set 2 V -1 05/04/19, 11:12

    As sys-admin patch2 works in web-modul 'page'. The modal wizard is broken, when in web-modul 'list' clickin action icon for add content-element in top of the table-list 'page-content'. Does not matter if 'mod.web_layout.disableNewContentElementWizard=1' is set or not.
  11. Andreas Kienast uploaded patch set 3 05/04/19, 13:12

  12. TYPO3com voted on patch set 3 V -1 05/04/19, 13:26 Completed build in 14m 03s on Sat, 4 May, 03:26 PM Test Summary: 47475 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33713

  13. Andreas Kienast uploaded patch set 4 05/05/19, 11:00

  14. TYPO3com voted on patch set 4 V +1 05/05/19, 11:12 Completed build in 11m 41s on Sun, 5 May, 01:12 PM Test Summary: 47475 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33714

  15. Joerg Kummer commented on patch set 4 V +1 05/05/19, 12:34

    Faboulus - various tests passed from my side. I'm not familiar with typescript - therfore no code review.
  16. Guido Schmechel voted on patch set 4 V +1 05/05/19, 18:19

  17. Susi Moog voted on patch set 4 V +1 CR +1 05/05/19, 18:54

  18. Markus Klein voted on patch set 4 CR +1 05/05/19, 20:33

  19. Susi Moog voted on patch set 4 V +2 CR +2 05/06/19, 04:58

  20. Susi Moog merged patch set 5 05/06/19, 04:58