Review main Merged

60631[TASK] Better example for FlashMessage finisher

TYPO3com CR +2 V +2 Easy +12 −11 updated 06/05/19, 19:12

Commit message

- Show how to use messageArguments
- messageCode is mandatory (Don't know why, but yes it is)
--> As it is mandatory, it does not make sense to write `if needed`
- remove `Default value` from mandatory options
--> As all calls in TYPO3 Core are strict types, a value like `null`
will throw an Exception

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Jörg Bösche +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. TYPO3com uploaded patch set 1 04/30/19, 08:11

  2. TYPO3com voted on patch set 1 V +1 04/30/19, 08:26 Completed build in 14m 31s on Tue, 30 Apr, 10:26 AM Test Summary: 47472 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33666

  3. Tomas Norre Mikkelsen commented on patch set 1 05/13/19, 18:43

    Index.rst:2220

    Why having the messageArguments: - 'TYPO3' on a seperate line? on line 2231 it's all at one line.
  4. Anja Leichsenring commented on patch set 1 05/19/19, 06:58

    Index.rst:2220 Reply Unresolved

    I'd say for demo reasons. Both formats are just fine.
  5. Jörg Bösche commented on patch set 1 V +1 CR +1 05/19/19, 20:21

    I find the indents in the documentary completely ok. A better example would of course be a message with 2 values as arguments.
  6. Daniel Goerz voted on patch set 1 V +2 CR +2 06/05/19, 19:12

  7. Daniel Goerz merged patch set 2 06/05/19, 19:12