Review 9.5 Merged

60633[BUGFIX] Only show records from current language in XML Sitemap

Richard Haeser CR +2 V +2 Normal +130 −18 updated 04/30/19, 14:42

Commit message

When generating the XML sitemap for records, the language of the
records will be checked. Only records from the current language or
all languages are added to the XML sitemap.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Riny van Tiggelen +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Riny van Tiggelen +1
    • TYPO3com +1 CI

Issues 2

Files 4

Review log 1015

  1. Richard Haeser commented on patch set 1 04/30/19, 12:26

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/seo/Tests/Functional/Fixtures/pages-sitemap.xml * typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapRecordsTest.php
  2. TYPO3com voted on patch set 1 V -1 04/30/19, 12:27 Completed build in 11s on Tue, 30 Apr, 02:27 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-627

  3. Richard Haeser uploaded patch set 2 04/30/19, 12:39

  4. TYPO3com voted on patch set 2 V -1 04/30/19, 12:39 Completed build in 10s on Tue, 30 Apr, 02:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-628

  5. Richard Haeser uploaded patch set 3 04/30/19, 12:52

  6. Richard Haeser commented on patch set 3 04/30/19, 12:53

    This change is ready for review.
  7. TYPO3com voted on patch set 3 V -1 04/30/19, 13:07 Completed build in 15m 00s on Tue, 30 Apr, 03:07 PM Test Summary: 12 of 50586 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-629

  8. Richard Haeser uploaded patch set 4 04/30/19, 13:36

  9. TYPO3com voted on patch set 4 V -1 04/30/19, 13:54 Completed build in 18m 01s on Tue, 30 Apr, 03:54 PM Test Summary: 6 of 50583 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-630

  10. Richard Haeser uploaded patch set 5 04/30/19, 13:55

  11. TYPO3com voted on patch set 5 V +1 04/30/19, 14:07 Completed build in 11m 48s on Tue, 30 Apr, 04:07 PM Test Summary: 50115 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-631

  12. Riny van Tiggelen voted on patch set 5 CR +1 04/30/19, 14:09

  13. Riny van Tiggelen voted on patch set 5 V +1 04/30/19, 14:09

  14. Richard Haeser voted on patch set 5 V +2 CR +2 04/30/19, 14:42

  15. Richard Haeser merged patch set 6 04/30/19, 14:42