60635[TASK] Add functional tests for hreflang tag generation
Commit message
Review
-
Code review CR +2 Done
- Tymoteusz Motylewski +2
- Benni Mack +1
-
Verified V +2 Done
- Tymoteusz Motylewski +2
- Jonas Eberle +1
- Benni Mack +1
- TYPO3com +1 CI
Issues 2
Files 5
- typo3/sysext/seo/Classes/HrefLang/HrefLangGenerator.php+21 −3
- typo3/sysext/seo/Tests/Functional/Fixtures/HrefLang.typoscript2new+12 −0
- typo3/sysext/seo/Tests/Functional/Fixtures/HrefLangScenario.ymlnew+44 −0
- typo3/sysext/seo/Tests/Functional/HrefLang/HrefLangGeneratorTest.phpnew+172 −0
- typo3/sysext/seo/Tests/Unit/HrefLang/HrefLangGeneratorTest.php+4 −4
Review log 1216
-
Richard Haeser uploaded patch set 1 04/30/19, 19:42
-
Richard Haeser updated the commit message in patch set 2 04/30/19, 19:43
-
TYPO3com voted on patch set 1 V +1 04/30/19, 19:57 Completed build in 15m 22s on Tue, 30 Apr, 09:57 PM Test Summary: 47484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33674
-
TYPO3com voted on patch set 2 V +1 04/30/19, 19:59 Completed build in 15m 23s on Tue, 30 Apr, 09:59 PM Test Summary: 47484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33675
-
André Buchmann voted on patch set 2 V +1 CR +1 05/03/19, 15:10
-
Benni Mack commented on patch set 2 05/05/19, 18:14
-
Frank Nägler commented on patch set 2 V +1 05/05/19, 19:41
HrefLang.typoscript:4Reply Unresolvedyes, removed in 8.0 -
Richard Haeser uploaded patch set 3 05/06/19, 06:42
-
TYPO3com voted on patch set 3 V +1 05/06/19, 06:59 Completed build in 16m 08s on Mon, 6 May, 08:59 AM Test Summary: 47484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33722
-
Richard Haeser uploaded patch set 4 05/06/19, 10:42
-
Benni Mack voted on patch set 4 V +1 CR +1 05/06/19, 10:44
-
TYPO3com voted on patch set 4 V +1 05/06/19, 10:59 Completed build in 16m 30s on Mon, 6 May, 12:59 PM Test Summary: 47482 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33728
-
Jonas Eberle commented on patch set 4 V +1 05/06/19, 17:12
Verified by changing fixtures. Test results are plausible. -
Tymoteusz Motylewski voted on patch set 4 V +1 CR +1 05/06/19, 21:22
-
Tymoteusz Motylewski voted on patch set 4 V +2 CR +2 05/06/19, 21:24
-
Tymoteusz Motylewski merged patch set 5 05/06/19, 21:24
HrefLang.typoscript:4