Review main Merged

60635[TASK] Add functional tests for hreflang tag generation

Richard Haeser CR +2 V +2 Hard +253 −7 updated 05/06/19, 21:24

Commit message

To make sure rendering of hreflang tags will not change unexpectedly,
some functional tests are added.

Review

  • Code review CR +2 Done
    • Tymoteusz Motylewski +2
    • Benni Mack +1
  • Verified V +2 Done
    • Tymoteusz Motylewski +2
    • Jonas Eberle +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 2

Files 5

Review log 1216

  1. Richard Haeser uploaded patch set 1 04/30/19, 19:42

  2. Richard Haeser updated the commit message in patch set 2 04/30/19, 19:43

  3. TYPO3com voted on patch set 1 V +1 04/30/19, 19:57 Completed build in 15m 22s on Tue, 30 Apr, 09:57 PM Test Summary: 47484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33674

  4. TYPO3com voted on patch set 2 V +1 04/30/19, 19:59 Completed build in 15m 23s on Tue, 30 Apr, 09:59 PM Test Summary: 47484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33675

  5. André Buchmann voted on patch set 2 V +1 CR +1 05/03/19, 15:10

  6. Benni Mack commented on patch set 2 05/05/19, 18:14

    HrefLang.typoscript:4

    xhtml_cleaning does not exist anymore btw...
  7. Frank Nägler commented on patch set 2 V +1 05/05/19, 19:41

    HrefLang.typoscript:4 Reply Unresolved

    yes, removed in 8.0
  8. Richard Haeser uploaded patch set 3 05/06/19, 06:42

  9. TYPO3com voted on patch set 3 V +1 05/06/19, 06:59 Completed build in 16m 08s on Mon, 6 May, 08:59 AM Test Summary: 47484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33722

  10. Richard Haeser uploaded patch set 4 05/06/19, 10:42

  11. Benni Mack voted on patch set 4 V +1 CR +1 05/06/19, 10:44

  12. TYPO3com voted on patch set 4 V +1 05/06/19, 10:59 Completed build in 16m 30s on Mon, 6 May, 12:59 PM Test Summary: 47482 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33728

  13. Jonas Eberle commented on patch set 4 V +1 05/06/19, 17:12

    Verified by changing fixtures. Test results are plausible.
  14. Tymoteusz Motylewski voted on patch set 4 V +1 CR +1 05/06/19, 21:22

  15. Tymoteusz Motylewski voted on patch set 4 V +2 CR +2 05/06/19, 21:24

  16. Tymoteusz Motylewski merged patch set 5 05/06/19, 21:24