60637[BUGFIX] Allow TypoScript conditions to access PageArguments
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Georg Ringer +1
- Guido Schmechel +1
- Frank Nägler +1
- Andreas Kienast +1
- Helmut Hummel +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Guido Schmechel +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1011
-
Benni Mack uploaded patch set 1 04/30/19, 20:37
-
TYPO3com voted on patch set 1 V +1 04/30/19, 20:53 Completed build in 15m 46s on Tue, 30 Apr, 10:53 PM Test Summary: 47475 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33677
-
Guido Schmechel voted on patch set 1 V +1 CR +1 05/03/19, 06:28
-
Georg Ringer voted on patch set 1 CR +1 05/03/19, 20:36
-
Andreas Kienast voted on patch set 1 CR +1 05/04/19, 08:15
-
Helmut Hummel voted on patch set 1 CR +1 05/04/19, 10:11
-
Frank Nägler commented on patch set 1 CR +1 05/04/19, 19:49
-
Benni Mack commented on patch set 1 05/05/19, 19:19
RequestWrapper.php:82Reply Unresolvedhmm, I'd rather keep it like this for now, as Routing could return the SiteRouteResult as well, if somebody uses TypoScript condition matcher in a middleware before PageResolver middleware. -
Benjamin Franzke voted on patch set 1 V +2 CR +2 05/06/19, 05:39
-
Benjamin Franzke merged patch set 2 05/06/19, 05:40
-
Susi Moog commented on patch set 2 01/12/20, 17:18
this should have had a rst file as the conditions and their functions are all documented.
RequestWrapper.php:82