Review main Merged

60637[BUGFIX] Allow TypoScript conditions to access PageArguments

Benni Mack CR +2 V +2 Easy +6 −0 updated 01/12/20, 17:18

Commit message

In order to access resolved route parts by enhancers,
the TypoScript RequestWrapper should allow to access
the PageArguments object.

This way, it is easier to migrate existing conditions like

[globalVar = GP:singlepartner > 0]

to

[request.getPageArguments().get('singlepartner') > 0]

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Guido Schmechel +1
    • Frank Nägler +1
    • Andreas Kienast +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Guido Schmechel +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1011

  1. Benni Mack uploaded patch set 1 04/30/19, 20:37

  2. TYPO3com voted on patch set 1 V +1 04/30/19, 20:53 Completed build in 15m 46s on Tue, 30 Apr, 10:53 PM Test Summary: 47475 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33677

  3. Guido Schmechel voted on patch set 1 V +1 CR +1 05/03/19, 06:28

  4. Georg Ringer voted on patch set 1 CR +1 05/03/19, 20:36

  5. Andreas Kienast voted on patch set 1 CR +1 05/04/19, 08:15

  6. Helmut Hummel voted on patch set 1 CR +1 05/04/19, 10:11

  7. Frank Nägler commented on patch set 1 CR +1 05/04/19, 19:49

    RequestWrapper.php:82

    not sure about the naming, I know PageArguments implements RouteResultInterface. but maybe use a name like getRouteResult() ?
  8. Benni Mack commented on patch set 1 05/05/19, 19:19

    RequestWrapper.php:82 Reply Unresolved

    hmm, I'd rather keep it like this for now, as Routing could return the SiteRouteResult as well, if somebody uses TypoScript condition matcher in a middleware before PageResolver middleware.
  9. Benjamin Franzke voted on patch set 1 V +2 CR +2 05/06/19, 05:39

  10. Benjamin Franzke merged patch set 2 05/06/19, 05:40

  11. Susi Moog commented on patch set 2 01/12/20, 17:18

    this should have had a rst file as the conditions and their functions are all documented.