60638[BUGFIX] Proper form definition validation if backend language changes
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Sascha Rademacher +1
- Tobi Kretschmann +1
- Julian Geils +1
-
Verified V +2 Done
- Susi Moog +2
- Sascha Rademacher +1
- Tobi Kretschmann +1
- Julian Geils +1
- TYPO3com +1 CI
Issues 1
Files 8
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Validators/CreatableFormElementPropertiesValidator.php+46 −12
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Validators/CreatablePropertyCollectionElementPropertiesValidator.php+40 −14
- typo3/sysext/form/Classes/Domain/Configuration/ConfigurationService.php+27 −4
- typo3/sysext/form/Classes/Service/TranslationService.php+42 −0
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinition/Validators/CreatableFormElementPropertiesValidatorTest.php+1 −1
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinition/Validators/CreatablePropertyCollectionElementPropertiesValidatorTest.php+1 −1
- typo3/sysext/form/Tests/Unit/Domain/Configuration/ConfigurationServiceTest.php+6 −0
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinitionValidationServiceTest.php+30 −1
Review log 1014
-
Ralf Zimmermann uploaded patch set 1 05/01/19, 17:45
-
TYPO3com voted on patch set 1 V +1 05/01/19, 18:00 Completed build in 14m 49s on Wed, 1 May, 08:00 PM Test Summary: 47483 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33682
-
Ralf Zimmermann commented on patch set 2 05/01/19, 18:04
Published edit on patch set 1. -
Ralf Zimmermann uploaded patch set 3 05/01/19, 18:12
-
Ralf Zimmermann commented on patch set 4 05/01/19, 18:14
Published edit on patch set 3. -
TYPO3com voted on patch set 2 V +1 05/01/19, 18:24 Completed build in 19m 40s on Wed, 1 May, 08:24 PM Test Summary: 47483 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33683
-
TYPO3com voted on patch set 3 V +1 05/01/19, 18:35 Completed build in 18m 46s on Wed, 1 May, 08:35 PM Test Summary: 47483 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33684
-
TYPO3com voted on patch set 4 V +1 05/01/19, 18:43 Completed build in 26m 48s on Wed, 1 May, 08:43 PM Test Summary: 47483 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33685
-
Tobi Kretschmann voted on patch set 4 V +1 10/07/19, 07:42
-
Tobi Kretschmann voted on patch set 4 CR +1 10/07/19, 07:53
-
Sascha Rademacher voted on patch set 4 V +1 CR +1 10/07/19, 08:21
-
Julian Geils voted on patch set 4 V +1 CR +1 10/07/19, 09:25
-
Susi Moog voted on patch set 4 V +2 CR +2 10/26/19, 09:09
-
Susi Moog merged patch set 5 10/26/19, 09:09