Review 9.5 Merged

60639[BUGFIX] Proper form definition validation if backend language changes

Ralf Zimmermann CR +2 V +2 Normal +198 −33 updated 10/26/19, 09:10

Commit message

If a form element property is not defined through a form editor
inspector, the "predefinedDefaults" value from the form editor setup
will be used for some data integrity checks (such properties are
immutable).

Now, such checks against the "predefinedDefaults" values are *only* used
in scenarios where form elements are newely created. All the following
integrety checks on this value will be based on hmac validation.

In addition, this patchset fixes a faulty validation in the following
(edgy) scenario:

* backend language is EN
* open the form edtior and add a ContentElement form element
* switch to another browser tab and change the backend language to DE
* clear the cache
* go back to the form editor and click the save button

This is done by getting all translations (for all backend languages)
for the untranslated! "predefinedDefaults" value and compare the
(already translated) value (from the form definition) against the
possible translations from "predefinedDefaults".

There is an extended scenario which is out of scope for fixing:

* the same scenario as above + delete the previous chosen backend
  language within the maintenance tool

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Sascha Rademacher +1
    • Tobi Kretschmann +1
    • Julian Geils +1
    • Felix P. +1
  • Verified V +2 Done
    • Susi Moog +2
    • Sascha Rademacher +1
    • Tobi Kretschmann +1
    • Julian Geils +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 1014

  1. Ralf Zimmermann uploaded patch set 1 05/01/19, 17:50

  2. TYPO3com voted on patch set 1 V +1 05/01/19, 18:02 Completed build in 12m 28s on Wed, 1 May, 08:02 PM Test Summary: 50138 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-635

  3. Ralf Zimmermann commented on patch set 2 05/01/19, 18:04

    Published edit on patch set 1.
  4. Ralf Zimmermann uploaded patch set 3 05/01/19, 18:11

  5. Ralf Zimmermann commented on patch set 4 05/01/19, 18:15

    Published edit on patch set 3.
  6. TYPO3com voted on patch set 2 V +1 05/01/19, 18:20 Completed build in 15m 36s on Wed, 1 May, 08:20 PM Test Summary: 50138 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-636

  7. TYPO3com voted on patch set 3 V +1 05/01/19, 18:31 Completed build in 19m 40s on Wed, 1 May, 08:31 PM Test Summary: 50138 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-637

  8. TYPO3com voted on patch set 4 V +1 05/01/19, 18:41 Completed build in 24m 40s on Wed, 1 May, 08:41 PM Test Summary: 50138 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-638

  9. Tobi Kretschmann commented on patch set 4 V +1 CR +1 05/03/19, 13:47

    Tested in V9.5 and V8.7!
  10. Julian Geils voted on patch set 4 V +1 CR +1 10/07/19, 09:26

  11. Sascha Rademacher voted on patch set 4 V +1 CR +1 10/08/19, 12:30

  12. Felix P. voted on patch set 4 CR +1 10/08/19, 12:50

  13. Susi Moog voted on patch set 4 V +2 CR +2 10/26/19, 09:09

  14. Susi Moog merged patch set 5 10/26/19, 09:10