60639[BUGFIX] Proper form definition validation if backend language changes
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Sascha Rademacher +1
- Tobi Kretschmann +1
- Julian Geils +1
- Felix P. +1
-
Verified V +2 Done
- Susi Moog +2
- Sascha Rademacher +1
- Tobi Kretschmann +1
- Julian Geils +1
- TYPO3com +1 CI
Issues 1
Files 8
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Validators/CreatableFormElementPropertiesValidator.php+46 −12
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Validators/CreatablePropertyCollectionElementPropertiesValidator.php+40 −14
- typo3/sysext/form/Classes/Domain/Configuration/ConfigurationService.php+32 −4
- typo3/sysext/form/Classes/Service/TranslationService.php+42 −0
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinition/Validators/CreatableFormElementPropertiesValidatorTest.php+1 −1
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinition/Validators/CreatablePropertyCollectionElementPropertiesValidatorTest.php+1 −1
- typo3/sysext/form/Tests/Unit/Domain/Configuration/ConfigurationServiceTest.php+6 −0
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinitionValidationServiceTest.php+30 −1
Review log 1014
-
Ralf Zimmermann uploaded patch set 1 05/01/19, 17:50
-
TYPO3com voted on patch set 1 V +1 05/01/19, 18:02 Completed build in 12m 28s on Wed, 1 May, 08:02 PM Test Summary: 50138 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-635
-
Ralf Zimmermann commented on patch set 2 05/01/19, 18:04
Published edit on patch set 1. -
Ralf Zimmermann uploaded patch set 3 05/01/19, 18:11
-
Ralf Zimmermann commented on patch set 4 05/01/19, 18:15
Published edit on patch set 3. -
TYPO3com voted on patch set 2 V +1 05/01/19, 18:20 Completed build in 15m 36s on Wed, 1 May, 08:20 PM Test Summary: 50138 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-636
-
TYPO3com voted on patch set 3 V +1 05/01/19, 18:31 Completed build in 19m 40s on Wed, 1 May, 08:31 PM Test Summary: 50138 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-637
-
TYPO3com voted on patch set 4 V +1 05/01/19, 18:41 Completed build in 24m 40s on Wed, 1 May, 08:41 PM Test Summary: 50138 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-638
-
Tobi Kretschmann commented on patch set 4 V +1 CR +1 05/03/19, 13:47
Tested in V9.5 and V8.7! -
Julian Geils voted on patch set 4 V +1 CR +1 10/07/19, 09:26
-
Sascha Rademacher voted on patch set 4 V +1 CR +1 10/08/19, 12:30
-
Felix P. voted on patch set 4 CR +1 10/08/19, 12:50
-
Susi Moog voted on patch set 4 V +2 CR +2 10/26/19, 09:09
-
Susi Moog merged patch set 5 10/26/19, 09:10