Review main Merged

60647[BUGFIX] Make sure a twitter:card metatag is rendered

Richard Haeser CR +2 V +2 Easy +7 −0 updated 05/05/19, 19:25

Commit message

To get a valid Twitter card, you need to specify the type of card
by setting the twitter:card metatag. The value of this metatag is
now set to summary by default. If this value need to be changed, you
can use the MetaTag API and set the twitter:card property with the
replace option enabled.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Benni Mack +2
    • Guido Schmechel +1
    • Riny van Tiggelen +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Benni Mack +2
    • Guido Schmechel +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1315

  1. Richard Haeser uploaded patch set 1 05/03/19, 08:53

  2. Guido Schmechel commented on patch set 1 05/03/19, 09:04

    Can you plase add some small tests at typo3/sysext/seo/Tests/Unit/MetaTag/TwitterCardMetaTagManagerTest.php
  3. TYPO3com voted on patch set 1 V +1 05/03/19, 09:05 Completed build in 12m 42s on Fri, 3 May, 11:05 AM Test Summary: 47475 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33705

  4. Guido Schmechel commented on patch set 1 05/03/19, 09:06

    MetaTagGenerator.php:84 Unresolved

    If only two values (see TCA) are allowed, they should be checked here. Maybe you can work with constants and include them in TCA?
  5. Richard Haeser commented on patch set 1 05/03/19, 09:08

    > Patch Set 1: > > Can you plase add some small tests at typo3/sysext/seo/Tests/Unit/MetaTag/TwitterCardMetaTagManagerTest.php I was thinking about that, but didn't see the direct benefit from it because the unit test is only checking the AbstractMetaTagManager methods getProperty and renderProperty based on the settings of the manager.
  6. Guido Schmechel commented on patch set 1 05/03/19, 09:28

    > Patch Set 1: > > > Patch Set 1: > > > > Can you plase add some small tests at typo3/sysext/seo/Tests/Unit/MetaTag/TwitterCardMetaTagManagerTest.php > > I was thinking about that, but didn't see the direct benefit from it because the unit test is only checking the AbstractMetaTagManager methods getProperty and renderProperty based on the settings of the manager. You're right. It does make only sense if we check for the two possibilities and no other content is allowed.
  7. Richard Haeser commented on patch set 1 05/05/19, 11:26

    As discussed on slack, we will first make a bugfix to make sure a twitter:card metatag is rendered without having an option to select, in master only we will introduce the new feature.
  8. Richard Haeser voted on patch set 1 CR -1 05/05/19, 11:26

  9. Richard Haeser uploaded patch set 2 05/05/19, 11:35

  10. TYPO3com voted on patch set 2 V +1 05/05/19, 11:49 Completed build in 13m 42s on Sun, 5 May, 01:49 PM Test Summary: 47475 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33716

  11. Guido Schmechel voted on patch set 2 V +1 CR +1 05/05/19, 18:19

  12. Riny van Tiggelen voted on patch set 2 CR +1 05/05/19, 18:58

  13. Benni Mack voted on patch set 2 V +2 CR +2 05/05/19, 19:19

  14. Frank Nägler voted on patch set 2 V +2 CR +2 05/05/19, 19:20

  15. Frank Nägler merged patch set 3 05/05/19, 19:25