Review main Merged

60649[BUGFIX] Remove duplicated types of `AbstractFileFolder::$originalResource`

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 05/03/19, 20:34

Commit message

Technically, it's sufficient to annotate $originalResource as type of
ResourceInterface because all other annotated types implement the
interface anyway.

This also bypasses an issue with the rewritten ClassSchema, as it can't
handle multiple annotated types of a property and fails do determine a
class type.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benjamin Kott +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Andreas Kienast uploaded patch set 1 05/03/19, 14:59

  2. Oliver Klee voted on patch set 1 CR +1 05/03/19, 15:03

  3. TYPO3com voted on patch set 1 V +1 05/03/19, 15:13 Completed build in 14m 21s on Fri, 3 May, 05:13 PM Test Summary: 47475 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33708

  4. Benjamin Kott voted on patch set 1 V +1 CR +1 05/03/19, 16:40

  5. Georg Ringer voted on patch set 1 V +2 CR +2 05/03/19, 20:34

  6. Georg Ringer merged patch set 2 05/03/19, 20:34