Review 9.5 Merged

60651[BUGFIX] Remove duplicated types of `AbstractFileFolder::$originalResource`

Georg Ringer CR +2 V +2 Easy +2 −2 updated 05/07/19, 03:44

Commit message

Technically, it's sufficient to annotate $originalResource as type of
ResourceInterface because all other annotated types implement the
interface anyway.

This also bypasses an issue with the rewritten ClassSchema, as it can't
handle multiple annotated types of a property and fails do determine a
class type.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Georg Ringer +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Georg Ringer commented on patch set 1 05/03/19, 20:34

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 05/03/19, 20:48 Completed build in 13m 52s on Fri, 3 May, 10:48 PM Test Summary: 50130 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-642

  3. Oliver Klee voted on patch set 1 CR +1 05/03/19, 22:31

  4. Georg Ringer voted on patch set 1 V +2 CR +2 05/07/19, 03:44

  5. Georg Ringer merged patch set 2 05/07/19, 03:44