60656[BUGFIX] Support concurrent requests without 503 responses
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Jonas Eberle +1
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/core/Documentation/Changelog/9.5.x/Important-87980-PageIsBeingGeneratedMessageHasBeenRemoved.rstnew+34 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php3+36 −106
- typo3/sysext/t3editor/Resources/Private/tsref.xml+0 −8
- typo3/sysext/t3editor/Resources/Public/JavaScript/Mode/typoscript/typoscript.js+0 −1
Review log 910
-
Benjamin Franzke uploaded patch set 1 05/05/19, 19:25
-
TYPO3com voted on patch set 1 V +1 05/05/19, 19:42 Completed build in 15m 59s on Sun, 5 May, 09:42 PM Test Summary: 50130 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-645
-
Markus Klein commented on patch set 1 05/05/19, 20:41
-
Benjamin Franzke commented on patch set 1 05/05/19, 20:57
TypoScriptFrontendController.php:435ReplyYes, but it was changed from public to protected in v9 development cycle (public being deprecated). That means it has been added to the deprecations guards (public function __isset, __get, __set) already and thus is "deprecated". Now that it's actually unusued (rather then internal) I think it's fine to mark this deprecated (as it's technically still public accessible in v9, therefore I didn't drop it). Has also been done for $activeUrlHandlers equally before. -
Markus Klein commented on patch set 1 05/05/19, 22:27
TypoScriptFrontendController.php:435Reply UnresolvedThanks for the explanation, I indeed overlooked that. To be really "strict" about this, we actually have a breaking change here. The content of the variable changes - better it does not change anymore. ;-) -
Benjamin Franzke voted on patch set 1 V +1 CR +1 05/06/19, 12:34
-
Jonas Eberle commented on patch set 1 V +1 05/06/19, 13:53
Checked with 20 concurrent requests, before and after applying patch, with a page with a userunc that sleeps 10s. Result with page already in cache or not is as expected: All requests finish simultaneously after being rendered/fetched from cache. All return with status 200 after applying the patch - before the patch the first one returns with 503. -
Andreas Kienast voted on patch set 1 V +1 CR +1 05/06/19, 13:55
-
Benjamin Franzke voted on patch set 1 V +2 CR +2 05/06/19, 16:55
-
Benjamin Franzke merged patch set 2 05/06/19, 16:55
TypoScriptFrontendController.php:435