Review 9.5 Merged

60661[BUGFIX] Do not open EditDocumentController in modal

Susi Moog CR +2 V +2 Easy +12 −22 updated 05/06/19, 08:52

Commit message

If `mod.web_layout.disableNewContentElementWizard=1` is set, the
"New Content Element" wizard is skipped and EditDocumentController's
FormEngine is called directly.

In that case, the modal must not get opened as this doesn't work in
combination with FormEngine.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • Joerg Kummer +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 57

  1. Susi Moog uploaded patch set 1 05/06/19, 05:00

  2. Susi Moog updated the commit message in patch set 2 05/06/19, 05:01

  3. TYPO3com voted on patch set 1 V +1 05/06/19, 05:16 Completed build in 15m 53s on Mon, 6 May, 07:16 AM Test Summary: 50130 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-649

  4. TYPO3com voted on patch set 2 V +1 05/06/19, 05:21 Completed build in 19m 48s on Mon, 6 May, 07:21 AM Test Summary: 50130 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-650

  5. Joerg Kummer voted on patch set 2 V +1 05/06/19, 08:48

  6. Andreas Kienast voted on patch set 2 V +2 CR +2 05/06/19, 08:52

  7. Andreas Kienast merged patch set 3 05/06/19, 08:52