Review 9.5 Merged

60662[BUGFIX] Allow TypoScript conditions to access PageArguments

Benjamin Franzke CR +2 V +2 Easy +6 −0 updated 05/06/19, 06:47

Commit message

In order to access resolved route parts by enhancers,
the TypoScript RequestWrapper should allow to access
the PageArguments object.

This way, it is easier to migrate existing conditions like

[globalVar = GP:singlepartner > 0]

to

[request.getPageArguments().get('singlepartner') > 0]

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Benjamin Franzke commented on patch set 1 05/06/19, 05:40

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 05/06/19, 05:57 Completed build in 16m 25s on Mon, 6 May, 07:57 AM Test Summary: 50130 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-652

  3. Benjamin Franzke voted on patch set 1 V +2 CR +2 05/06/19, 06:47

  4. Benjamin Franzke merged patch set 2 05/06/19, 06:47