Review main Abandoned

60677[BUGFIX] Use RecordState within PseudoSite Display Condition

Benni Mack CR 0 V 0 Easy +11 −13 updated 07/01/19, 04:16

Commit message

Instead of juggling around with "l10n_parent" etc for the
PseudoSiteDisplayCondition and the actual logic when a
page slug field should be shown, use the RecordStateFactory
to find out the proper page ID, regardless of translations/versions
etc.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 57

  1. Benni Mack uploaded patch set 1 05/06/19, 15:17

  2. TYPO3com voted on patch set 1 V -1 05/06/19, 15:17 Completed build in 14s on Mon, 6 May, 05:17 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33738

  3. Benni Mack uploaded patch set 2 05/06/19, 15:19

  4. TYPO3com voted on patch set 2 V +1 05/06/19, 15:30 Completed build in 10m 26s on Mon, 6 May, 05:30 PM Test Summary: 47475 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33739

  5. Benni Mack commented on patch set 2 CR -1 05/06/19, 20:52

    needs more work...
  6. Riccardo De Contardi commented on patch set 2 V +1 05/06/19, 21:06

    I've repeated the test https://forge.typo3.org/issues/87963#note-4 on TYPO3 10.0.0-dev; - without the patch: a page not found exception is thrown ( #1518472189 TYPO3\CMS\Core\Error\Http\PageNotFoundException); and there is no way to change the slug of the second home page - with the patch: it is possible to change the slug of the second home and adjust it It is still possible to preview the folder, and it is a 404 page, too (but it should be correct). Please note that the sysfolder has the same level of the original "home" page, but it takes the error handling of the latter one.
  7. Benni Mack abandoned the change 07/01/19, 04:16

    abandoned for now