Review main Merged

60678[BUGFIX] Avoid showing password on MacBook touch bar in backend forms

Oliver Hader CR +2 V +2 Easy +10 −3 updated 05/07/19, 07:07

Commit message

The auto suggest feature of MacBook's touch bar shows information of
just entered passwords when editing a record containing a password
field in backend forms. The behavior only occurs when Safari is used
as client and touch bar word completion is activated.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Oliver Hader uploaded patch set 1 05/06/19, 20:11

  2. Oliver Hader updated the commit message in patch set 2 05/06/19, 20:21

  3. TYPO3com voted on patch set 1 V +1 05/06/19, 20:25 Completed build in 14m 05s on Mon, 6 May, 10:25 PM Test Summary: 47475 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33744

  4. TYPO3com voted on patch set 2 V +1 05/06/19, 20:36 Completed build in 14m 37s on Mon, 6 May, 10:36 PM Test Summary: 47475 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33745

  5. Benni Mack voted on patch set 2 V +1 CR +1 05/06/19, 20:57

  6. Andreas Kienast voted on patch set 2 V +2 CR +2 05/07/19, 06:56

  7. Andreas Kienast merged patch set 3 05/07/19, 06:56

  8. Frank Nägler voted on patch set 3 CR +1 05/07/19, 07:06

  9. Frank Nägler voted on patch set 3 V +1 05/07/19, 07:07