60691[SECURITY] Raise Fluid Standalone dependency
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
-
Verified V +2 Done
- Benni Mack +2
- TYPO3com +1 CI
Issues 1
Files 4
Review log 1114
-
Benni Mack uploaded patch set 1 05/07/19, 08:19
-
Claus Due commented on patch set 1 05/07/19, 08:26
-
Claus Due commented on patch set 1 05/07/19, 08:27
> Patch Set 1: > > (1 comment) I mean: even though the tarball delivered 2.5.4 we should not bump the *composer* dependency since you can still use composer with earlier versions (there may be concerns like people using aliases, people using stricter constraints, etc.). Tarball can ship 2.5.5 no problem :) -
Claus Due commented on patch set 1 05/07/19, 08:36
Minor typo: "which fixes and important XSS" -> "which fixes an important XSS" -
TYPO3com voted on patch set 1 V +1 05/07/19, 08:39 Completed build in 20m 02s on Tue, 7 May, 10:39 AM Test Summary: 80206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3505
-
Benni Mack updated the commit message in patch set 2 05/07/19, 08:43
-
Benni Mack commented on patch set 2 05/07/19, 08:50
> Patch Set 1: > > > Patch Set 1: > > > > (1 comment) > > I mean: even though the tarball delivered 2.5.4 we should not bump the *composer* dependency since you can still use composer with earlier versions (there may be concerns like people using aliases, people using stricter constraints, etc.). Tarball can ship 2.5.5 no problem :) Yes. Thought about that too. For composer-based installations we could actually just conflict and not raise the dependency. However, since tarballs use 2.5.4 (80% of our installations) and the composer-based installations run 2.6.x anyway, we're talking about a very edgy edge-case. I mean, if it'd be a regular upgrade, that'd be fine with me, but since we're talking about a sec issue, I think we should really restrict this more. Well, to put it this way: We're a bit under time pressure here, and using composer conflicts, setting the proper restrictions here sounds that we should rather fix this separately if an issue pops up. OK with you? After all, we're talking about composer-based installations, and we could easily change that for composer-based installations quickly again, if somebody runs into issues. -
Benni Mack updated the commit message in patch set 3 05/07/19, 08:50
-
Claus Due commented on patch set 2 CR +1 05/07/19, 08:51
Verified by reading, can only test with 9.x currently (will vote on other issue). -
TYPO3com voted on patch set 2 V +1 05/07/19, 09:08 Completed build in 24m 44s on Tue, 7 May, 11:08 AM Test Summary: 80206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3506
-
TYPO3com voted on patch set 3 V +1 05/07/19, 09:15 Completed build in 18m 34s on Tue, 7 May, 11:15 AM Test Summary: 80206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3507
-
Benni Mack voted on patch set 3 V +2 CR +2 05/07/19, 09:34
-
Benni Mack merged patch set 4 05/07/19, 09:34
-
Oliver Hader wrote 05/07/19, 10:27
Topic set to security
composer.json:57Unresolved