6071[BUGFIX] Stylesheet for confirmation view missing in form sysext
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
- Xavier Perseguers +1
-
Verified V +2
- Oliver Hader +2
Files 5
- typo3/sysext/form/Classes/View/Confirmation/Confirmation.php+14 −0
- typo3/sysext/form/Classes/View/Wizard/Wizard.php1+1 −1
- typo3/sysext/form/Resources/Public/CSS/Wizard/Form.cssnew+195 −0
- typo3/sysext/form/Resources/Public/CSS/Confirmation.cssnew+204 −0
- typo3/sysext/form/Resources/Public/CSS/Form.css+24 −15
Review log 18
-
Oliver Hader commented on patch set 1 10/23/11, 17:46
Damn, forgot to set the depency: https://review.typo3.org/#change,6042 -
Oliver Hader uploaded patch set 2 10/23/11, 17:46
-
Oliver Hader uploaded patch set 3 10/23/11, 17:46
-
Oliver Hader commented on patch set 3 10/23/11, 17:46
Okay - modified commit message and now set commit dependency -
Oliver Hader uploaded patch set 4 10/23/11, 17:46
-
Oliver Hader uploaded patch set 5 10/23/11, 17:46
-
Oliver Hader uploaded patch set 6 10/23/11, 17:46
-
Oliver Hader commented on patch set 6 10/23/11, 17:46
(1 inline comment) Copied Form.css to WIzard/Form.css - the CSS in frontend and backend was the same and I guess this was not intended since all FORM elements would have been covered by that in the frontend... -
Xavier Perseguers commented on patch set 6 10/23/11, 17:46
Looks good to me, but someone else must approve -
Steffen Gebert commented on patch set 1 10/23/11, 17:46
(1 inline comment)Maybe somewhere mention that this is about FORM? -
Mr. Jenkins commented on patch set 1 10/23/11, 17:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2202/ : SUCCESS -
Mr. Jenkins commented on patch set 2 10/23/11, 17:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2203/ : SUCCESS -
Mr. Jenkins commented on patch set 3 10/23/11, 17:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2204/ : SUCCESS -
Mr. Jenkins commented on patch set 4 10/23/11, 17:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2205/ : SUCCESS -
Mr. Jenkins commented on patch set 5 10/23/11, 17:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2206/ : SUCCESS -
Mr. Jenkins commented on patch set 6 10/23/11, 17:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2207/ : SUCCESS -
Oliver Hader commented on patch set 6 V 0 10/23/11, 17:46
by team member; Looks good to me, approved -
Oliver Hader merged patch set 6 10/23/11, 17:46