Review main Merged

60710[BUGFIX] Make php-intl work with older ICU versions

Benni Mack CR +2 V +2 Easy +32 −10 updated 05/09/19, 06:49

Commit message

On old OS with ICU < 4.6, the constant INTL_IDNA_VARIANT_UTS46
is not available, even if php-intl is installed.

Therefore, a wrapper is created in HttpUtility to check
if the constant is available, then uses INTL_IDNA_VARIANT_UTS46
otherwise the 2003 version of the HttpUtility.

Also see the section about INTL_IDNA_VARIANT_UTS46 within
https://www.php.net/manual/en/intl.constants.php

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Sven Juergens +1
    • Kevin Meckl +1
    • Sebastian Fischer +1
    • Timo Poppinga +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Timo Poppinga +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1719

  1. Benni Mack uploaded patch set 1 05/07/19, 13:09

  2. Benni Mack updated the commit message in patch set 2 05/07/19, 13:11

  3. Mathias Brodala commented on patch set 2 05/07/19, 13:14

    How about requiring symfony/polyfill-intl-idn instead? This package polyfills the mentioned constant and many more.
  4. Mathias Brodala commented on patch set 2 05/07/19, 13:15

    > Patch Set 2: > > How about requiring symfony/polyfill-intl-idn instead? This package polyfills the mentioned constant and many more. OK just saw, we already do that. So I'd say that's something that needs to be fixed in symfony/polyfill-intl-idn. What do you think?
  5. Benni Mack commented on patch set 2 05/07/19, 13:18

    > Patch Set 2: > > > Patch Set 2: > > > > How about requiring symfony/polyfill-intl-idn instead? This package polyfills the mentioned constant and many more. > > OK just saw, we already do that. So I'd say that's something that needs to be fixed in symfony/polyfill-intl-idn. What do you think? thought of that too and looked into it already. might take more work, as I found out that the UTS46 algorithm in their setup is incomplete.
  6. Sven Juergens voted on patch set 2 CR +1 05/07/19, 13:19

  7. Andreas Kienast commented on patch set 2 05/07/19, 13:20

    > OK just saw, we already do that. So I'd say that's something that needs to be fixed in symfony/polyfill-intl-idn. What do you think? That wouldn't help, the polyfill isn't taken into consideration when `idn_to_ascii` is available, which is given when php-intl is installed.
  8. Mathias Brodala commented on patch set 2 05/07/19, 13:22

    > Patch Set 2: > > > OK just saw, we already do that. So I'd say that's something that needs to be fixed in symfony/polyfill-intl-idn. What do you think? > > That wouldn't help, the polyfill isn't taken into consideration when `idn_to_ascii` is available, which is given when php-intl is installed. Yeah, that's the current logic which would need to be changed to explicitly define the constant if it is not defined, no matter if the real "intl" is available or not. But as Benni wrote there are probably more implications to that ...
  9. Andreas Kienast voted on patch set 2 CR +1 05/07/19, 13:22

  10. Andreas Kienast commented on patch set 2 05/07/19, 13:23

    > Yeah, that's the current logic which would need to be changed to explicitly define the constant if it is not defined, no matter if the real "intl" is available or not. Ok, I misunderstood your remark then.
  11. TYPO3com voted on patch set 1 V +1 05/07/19, 13:23 Completed build in 13m 52s on Tue, 7 May, 03:23 PM Test Summary: 47670 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33770

  12. TYPO3com voted on patch set 2 V +1 05/07/19, 13:25 Completed build in 12m 55s on Tue, 7 May, 03:25 PM Test Summary: 47670 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33771

  13. Andreas Kienast commented on patch set 2 05/07/19, 13:31

    Verified by remote live demonstration
  14. Andreas Kienast voted on patch set 2 V +1 05/07/19, 13:31

  15. Kevin Meckl voted on patch set 2 CR +1 05/08/19, 13:15

  16. Timo Poppinga voted on patch set 2 V +1 CR +1 05/08/19, 13:16

  17. Andreas Kienast voted on patch set 2 V +2 CR +2 05/08/19, 21:02

  18. Andreas Kienast merged patch set 3 05/08/19, 21:05

  19. Sebastian Fischer voted on patch set 3 CR +1 05/09/19, 06:49