Review 9.5 Merged

60711[BUGFIX] Make php-intl work with older ICU versions

Benni Mack CR +2 V +2 Easy +22 −2 updated 05/08/19, 21:05

Commit message

On old OS with ICU < 4.6, the constant INTL_IDNA_VARIANT_UTS46
is not available, even if php-intl is installed.

Therefore, a wrapper is created in HttpUtility to check
if the constant is available, then uses INTL_IDNA_VARIANT_UTS46
otherwise the 2003 version of the HttpUtility.

Also see the section about INTL_IDNA_VARIANT_UTS46 within
https://www.php.net/manual/en/intl.constants.php

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Sven Juergens +1
    • Kevin Meckl +1
    • Timo Poppinga +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Timo Poppinga +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 910

  1. Benni Mack uploaded patch set 1 05/07/19, 13:25

  2. Andreas Kienast voted on patch set 1 CR +1 05/07/19, 13:26

  3. Benni Mack commented on patch set 1 05/07/19, 13:27

    Works on mittwald machines ;)
  4. Sven Juergens commented on patch set 1 CR +1 05/07/19, 13:29

    :)
  5. Andreas Kienast commented on patch set 1 V +1 05/07/19, 13:30

    Verified by remote live demonstration
  6. TYPO3com voted on patch set 1 V +1 05/07/19, 13:38 Completed build in 13m 15s on Tue, 7 May, 03:38 PM Test Summary: 50325 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-686

  7. Kevin Meckl voted on patch set 1 CR +1 05/08/19, 09:47

  8. Timo Poppinga voted on patch set 1 V +1 CR +1 05/08/19, 13:04

  9. Andreas Kienast voted on patch set 1 V +2 CR +2 05/08/19, 21:02

  10. Andreas Kienast merged patch set 2 05/08/19, 21:05