60713[BUGFIX] Add TSFE->tmpl->start() on cache hit
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 4
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php1+2 −0
- typo3/sysext/frontend/Tests/Functional/Middleware/Basic.tsnew+4 −0
- typo3/sysext/frontend/Tests/Functional/Middleware/fixtures.xmlnew+9 −0
- typo3/sysext/frontend/Tests/Functional/Middleware/PrepareTypoScriptFrontendRenderingTest.php5new+107 −0
Review log 2230
Show 35 earlier messages
-
Sven Carstens uploaded patch set 1 05/07/19, 13:50
-
Sven Carstens wrote 05/07/19, 13:51
Description set to "Failing test to demonstrate issue" -
Sven Carstens updated the commit message in patch set 2 05/07/19, 13:52
-
TYPO3com voted on patch set 1 V -1 05/07/19, 13:56 Completed build in 25s on Tue, 7 May, 03:56 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33773
-
TYPO3com voted on patch set 2 V -1 05/07/19, 13:56 Completed build in 34s on Tue, 7 May, 03:56 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33774
-
Sven Carstens uploaded patch set 3 05/07/19, 14:01
-
TYPO3com voted on patch set 3 V -1 05/07/19, 14:02 Completed build in 12s on Tue, 7 May, 04:02 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33775
-
Sven Carstens uploaded patch set 4 05/07/19, 14:04
-
TYPO3com voted on patch set 4 V +1 05/07/19, 14:17 Completed build in 13m 22s on Tue, 7 May, 04:17 PM Test Summary: 47670 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33776
-
Manuel Selbach updated the commit message in patch set 5 05/08/19, 09:07
-
TYPO3com voted on patch set 5 V +1 05/08/19, 09:18 Completed build in 11m 48s on Wed, 8 May, 11:18 AM Test Summary: 47670 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33781
-
Georg Ringer commented on patch set 5 05/11/19, 05:38
TypoScriptFrontendController.php:1911Unresolvedlet's combine this into an elseif() -
Sven Carstens uploaded patch set 6 05/13/19, 05:37
-
Sven Carstens updated the commit message in patch set 7 05/13/19, 05:41
-
TYPO3com voted on patch set 6 V +1 05/13/19, 05:51 Completed build in 14m 30s on Mon, 13 May, 07:51 AM Test Summary: 47686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33831
-
TYPO3com voted on patch set 7 V +1 05/13/19, 05:55 Completed build in 13m 44s on Mon, 13 May, 07:55 AM Test Summary: 47686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33832
-
Sven Carstens commented on patch set 7 05/13/19, 05:56
> Patch Set 5: > > (1 comment) Done -
Sascha Rademacher voted on patch set 7 CR +1 10/10/19, 13:28
-
Benni Mack commented on patch set 7 CR -1 11/04/19, 13:08
Sorry, but this needs a bit love. Tests are not really matching the code. In addition, can we just use the DataSets for pagetrees (see SiteHandling Functionals in EXT:frontend) that we have instead of manually manipulating the rootline cache with static list within the tests? -
Benni Mack commented on patch set 7 11/22/19, 14:41
Had another look on this: If you add tmpl->start() on a cached hit, performance will degrade massively. However, I assume you have a custom middleware wanting to "boot up Extbase"? -
Sven Carstens commented on patch set 7 11/25/19, 07:51
> Patch Set 7: > > Had another look on this: If you add tmpl->start() on a cached hit, performance will degrade massively. > > However, I assume you have a custom middleware wanting to "boot up Extbase"? Yes, we are using an Extbase Repository inside of the Middleware. Only the alias to map to 'sys_files' is not present. The tmpl->start() was taken from the first non-cache hit and satisfied my needs. I have no clue how that should be done properly instead. -
Oliver Klee commented on patch set 7 11/25/19, 12:25
PrepareTypoScriptFrontendRenderingTest.php:2Unresolvedstrict, please. -
Oli Bartsch commented on patch set 7 11/25/19, 12:50
PrepareTypoScriptFrontendRenderingTest.php:22UnresolvedThis should be `TYPO3\CMS\Frontend\Http\RequestHandler`.PrepareTypoScriptFrontendRenderingTest.php:39Unresolved:voidPrepareTypoScriptFrontendRenderingTest.php:51Unresolved:voidPrepareTypoScriptFrontendRenderingTest.php:53UnresolvedCould you please format this. -
Benni Mack commented on patch set 7 11/25/19, 12:52
@Oli @Oliver: You are aware that this change won't make it in its current state? So looking at CGL changes for tests that do not make it (see all of my comments above) should not be relevant at this point. -
Oli Bartsch commented on patch set 7 11/25/19, 12:57
> Patch Set 7: > > @Oli @Oliver: You are aware that this change won't make it in its current state? So looking at CGL changes for tests that do not make it (see all of my comments above) should not be relevant at this point. Ah, you are right. I accidentally thought there was a new patchset uploaded since your comment. Thanks for the hint. -
Oliver Klee commented on patch set 7 11/25/19, 13:13
Thanks for the remark. No, I wasn't aware of this. Could you please mark your changesets that are not ready for review as WIP so that people don't waster their time on reviews? Thanks. -
Sven Carstens uploaded patch set 8 11/27/19, 08:09
-
TYPO3com voted on patch set 8 V -1 11/27/19, 08:09 Completed build in 15s on Wed, 27 Nov, 08:09 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38850
-
Benni Mack commented on patch set 8 12/10/19, 13:39
Please see https://github.com/b13/slimphp-bridge/blob/master/src/Middleware/ExtbaseBridge.php on how Extbase can be used without running the full middleware. The alternative (= you want to use Extbase without having to do the whole Page rendering) is to add a middleware at the very last (after the PrepareTypoScriptFrontendRendering middleware), and this should solve your issue. -
Sven Carstens abandoned the change 12/12/19, 10:06
In accordance with the prophecy and benni mack I close this issue. Solution should be more Extbase related and prevent Extbases usage of TSFE->tmpl->setup without proper initialization.