Review main Abandoned

60714[BUGFIX] impexp: Fix export when var/ is outside docroot

Rémy DANIEL CR 0 V 0 Easy +4 −4 updated 07/26/19, 12:38

Commit message

FAL API is not used anymore for transient files when saving an export
with "Save files in extra folder beside the export file".

This fix an exception when the var/transient directory is outside the
document root.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1112

  1. Rémy DANIEL uploaded patch set 1 05/07/19, 16:28

  2. TYPO3com voted on patch set 1 V +1 05/07/19, 16:41 Completed build in 13m 02s on Tue, 7 May, 06:41 PM Test Summary: 47670 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33777

  3. Rémy DANIEL voted on patch set 1 V +1 CR +1 05/07/19, 16:47

  4. Rémy DANIEL wrote 05/07/19, 16:49

    Removed Verified+1 by Rémy DANIEL <dogawaf@no-log.org>
  5. Rémy DANIEL wrote 05/07/19, 16:49

    Removed Code-Review+1 by Rémy DANIEL <dogawaf@no-log.org>
  6. Guido Schmechel commented on patch set 1 CR -1 05/24/19, 12:13

    ImportExportController.php:560

    The code could be a bit too simple. In particular, the rmdir meant. The delete function contains much more logic than a rm or rmdir. Also, unfortunately, the hooks/signals are ignored. For this reason I would give for the time being a -1.
  7. Susi Moog commented on patch set 1 CR +1 05/24/19, 12:22

    ImportExportController.php:560 Reply Unresolved

    In this case I think that's ok, as we cannot use FAL here sensibly (and it's imho wrong to have implemented that in the first place)
  8. Guido Schmechel wrote 05/24/19, 13:47

    Removed Code-Review-1 by Guido Schmechel <guido.schmechel@brandung.de>
  9. Guido Schmechel commented on patch set 1 CR +1 05/24/19, 13:48

    Maybe a little example
  10. Andreas Kienast voted on patch set 1 CR +1 06/21/19, 11:06

  11. Rémy DANIEL commented on patch set 1 06/21/19, 13:04

    > Patch Set 1: Code-Review+1 > > Maybe a little example See https://forge.typo3.org/issues/88293 for how to reproduce.
  12. Susi Moog abandoned the change 07/26/19, 12:38