60714[BUGFIX] impexp: Fix export when var/ is outside docroot
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1112
-
Rémy DANIEL uploaded patch set 1 05/07/19, 16:28
-
TYPO3com voted on patch set 1 V +1 05/07/19, 16:41 Completed build in 13m 02s on Tue, 7 May, 06:41 PM Test Summary: 47670 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33777
-
Rémy DANIEL voted on patch set 1 V +1 CR +1 05/07/19, 16:47
-
Rémy DANIEL wrote 05/07/19, 16:49
Removed Verified+1 by Rémy DANIEL <dogawaf@no-log.org> -
Rémy DANIEL wrote 05/07/19, 16:49
Removed Code-Review+1 by Rémy DANIEL <dogawaf@no-log.org> -
Guido Schmechel commented on patch set 1 CR -1 05/24/19, 12:13
ImportExportController.php:560The code could be a bit too simple. In particular, the rmdir meant. The delete function contains much more logic than a rm or rmdir. Also, unfortunately, the hooks/signals are ignored. For this reason I would give for the time being a -1. -
Susi Moog commented on patch set 1 CR +1 05/24/19, 12:22
ImportExportController.php:560Reply UnresolvedIn this case I think that's ok, as we cannot use FAL here sensibly (and it's imho wrong to have implemented that in the first place) -
Guido Schmechel wrote 05/24/19, 13:47
Removed Code-Review-1 by Guido Schmechel <guido.schmechel@brandung.de> -
Guido Schmechel commented on patch set 1 CR +1 05/24/19, 13:48
Maybe a little example -
Andreas Kienast voted on patch set 1 CR +1 06/21/19, 11:06
-
Rémy DANIEL commented on patch set 1 06/21/19, 13:04
> Patch Set 1: Code-Review+1 > > Maybe a little example See https://forge.typo3.org/issues/88293 for how to reproduce. -
Susi Moog abandoned the change 07/26/19, 12:38