Review 9.5 Abandoned

60715[BUGFIX] Check for data-url when opening content element wizard

Andreas Kienast CR 0 V 0 Easy +3 −2 updated 05/08/19, 09:17

Commit message

With #88075, the markup of the content buttons was changed to fix the
mentioned behavior. However, extensions like gridelements use the
markup prior to that bugfix and are broken now, since they still rely
on the removed `data-url` attribute.

This patch adds a fallback that checks for `data-url` at first and then
uses `href`, if the first is not available.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 2

Review log 23

  1. Andreas Kienast uploaded patch set 1 05/08/19, 06:44

  2. TYPO3com voted on patch set 1 V +1 05/08/19, 06:58 Completed build in 13m 29s on Wed, 8 May, 08:58 AM Test Summary: 50325 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-687

  3. Andreas Kienast abandoned the change 05/08/19, 09:17

    Fixed in upstream gridelements