Review main Abandoned

60717[BUGFIX] Check for data-url when opening content element wizard

Andreas Kienast CR 0 V 0 Easy +3 −2 updated 05/08/19, 09:16

Commit message

With #88075, the markup of the content buttons was changed to fix the
mentioned behavior. However, extensions like gridelements use the
markup prior to that bugfix and are broken now, since they still rely
on the removed `data-url` attribute.

This patch adds a fallback that checks for `data-url` at first and then
uses `href`, if the first is not available.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 2

Review log 79

  1. Andreas Kienast uploaded patch set 1 05/08/19, 06:47

  2. Markus Klein commented on patch set 1 05/08/19, 07:01

    PageActions.ts:234

    data('url)' to be consistent with next line
  3. TYPO3com voted on patch set 1 V -1 05/08/19, 07:02 Completed build in 10m 14s on Wed, 8 May, 09:02 AM Test Summary: 7 of 48063 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33779

  4. Andreas Kienast commented on patch set 1 05/08/19, 07:12

    PageActions.ts:234 Reply

    Having attr() is consistent with attr('href') ;)
  5. TYPO3com voted on patch set 1 V +1 05/08/19, 07:13 Completed build in 31m 36s on Wed, 8 May, 09:13 AM Test Summary: 47670 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33779

  6. Markus Klein commented on patch set 1 05/08/19, 09:02

    Was fixed in gridelements, do we still want this patch?
  7. Jonas Eberle commented on patch set 1 05/08/19, 09:04

    PageActions.ts:234 Reply Unresolved

    but dataset / $().data has an own API, href doesn't - and IMHO it should be used
  8. Jonas Eberle commented on patch set 1 05/08/19, 09:10

    You are right. I guess this patch is not needed any more, not using data-url in gridelements seems more sane. Thanks for the quick reaction anyways!
  9. Andreas Kienast abandoned the change 05/08/19, 09:16

    Fixed in upstream gridelements