60717[BUGFIX] Check for data-url when opening content element wizard
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 2
Files 2
Review log 79
-
Andreas Kienast uploaded patch set 1 05/08/19, 06:47
-
Markus Klein commented on patch set 1 05/08/19, 07:01
-
TYPO3com voted on patch set 1 V -1 05/08/19, 07:02 Completed build in 10m 14s on Wed, 8 May, 09:02 AM Test Summary: 7 of 48063 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33779
-
Andreas Kienast commented on patch set 1 05/08/19, 07:12
PageActions.ts:234ReplyHaving attr() is consistent with attr('href') ;) -
TYPO3com voted on patch set 1 V +1 05/08/19, 07:13 Completed build in 31m 36s on Wed, 8 May, 09:13 AM Test Summary: 47670 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33779
-
Markus Klein commented on patch set 1 05/08/19, 09:02
Was fixed in gridelements, do we still want this patch? -
Jonas Eberle commented on patch set 1 05/08/19, 09:04
PageActions.ts:234Reply Unresolvedbut dataset / $().data has an own API, href doesn't - and IMHO it should be used -
Jonas Eberle commented on patch set 1 05/08/19, 09:10
You are right. I guess this patch is not needed any more, not using data-url in gridelements seems more sane. Thanks for the quick reaction anyways! -
Andreas Kienast abandoned the change 05/08/19, 09:16
Fixed in upstream gridelements
PageActions.ts:234