Review main Merged

60722[BUGFIX] Fix language synchronization for inline relations with inline relations

Michael Stucki CR +2 V +2 Easy +3 −3 updated 01/27/20, 07:24

Commit message

If the language synchronization process is called on an inline
relation within another inline relation when there is more
than one language which should be synchronized, the process
fails with the following exception:

    #1486233164: Child record was not processed

The problem happens because of a non-unique cache identifier
which leads to incomplete operation.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 3

Files 1

Review log 1115

  1. Michael Stucki uploaded patch set 1 05/08/19, 22:50

  2. TYPO3com voted on patch set 1 V +1 05/08/19, 23:04 Completed build in 13m 36s on Thu, 9 May, 01:04 AM Test Summary: 47670 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33796

  3. Andreas Kienast commented on patch set 1 V -1 08/05/19, 13:02

    Can you please provide tests?
  4. Andreas Wolf rebased onto patch set 2 11/05/19, 07:32

  5. Andreas Wolf commented on patch set 2 11/05/19, 07:34

    Rebased b/c I need this as the base for one of my fixes. It works, but as Andi mentioned, there should be tests added.
  6. TYPO3com voted on patch set 2 V -1 11/05/19, 07:45 Completed build in 13m 07s on Tue, 5 Nov, 07:45 AM Test Summary: 1 of 48482 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37997

  7. Oliver Hader wrote 01/09/20, 10:29

    Topic set to DataHandler/l10n
  8. Benni Mack uploaded patch set 3 01/14/20, 19:07

  9. TYPO3com voted on patch set 3 V -1 01/14/20, 19:16 Completed build in 09m 04s on Tue, 14 Jan, 07:16 PM Test Summary: 69594 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39933

  10. TYPO3com voted on patch set 3 V +1 01/16/20, 12:43 Completed build in 12m 32s on Thu, 16 Jan, 12:43 PM Test Summary: 70367 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40036

  11. Benni Mack commented on patch set 3 V +1 CR +1 01/26/20, 12:37

    i failed to build tests for this use case, as this only works with a "broken" state (= when updating) to clean up. I'm all for adding this change, as it makes a lot of sense by reading and to make updates easier.
  12. Daniel Goerz voted on patch set 3 CR +1 01/26/20, 13:03

  13. Georg Ringer voted on patch set 3 V +1 CR +1 01/26/20, 13:20

  14. Benni Mack voted on patch set 3 V +2 CR +2 01/27/20, 07:24

  15. Benni Mack merged patch set 4 01/27/20, 07:24