Review TYPO3_8-7 Merged

60724[BUGFIX] Fix language synchronization for inline relations with inline relations

Michael Stucki CR +2 V +2 Easy +3 −3 updated 01/27/20, 11:05

Commit message

If the language synchronization process is called on an inline
relation within another inline relation when there is more
than one language which should be synchronized, the process
fails with the following exception:

    #1486233164: Child record was not processed

The problem happens because of a non-unique cache identifier
which leads to incomplete operation.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Robert Vock +1
    • Christian Eßl +1
  • Verified V +2 Done
    • Benni Mack +2
    • Robert Vock +1
    • Christian Eßl +1
    • TYPO3com +1 CI

Issues 3

Files 1

Review log 78

  1. Michael Stucki uploaded patch set 1 05/08/19, 23:00

  2. TYPO3com voted on patch set 1 V +1 05/08/19, 23:18 Completed build in 17m 59s on Thu, 9 May, 01:18 AM Test Summary: 80302 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3519

  3. Robert Vock commented on patch set 1 V +1 CR +1 05/27/19, 13:59

    I applied this patch in a TYPO3 8.7.26 instance via composer-patches and the error "Child record was not processed" went away. There were no duplicated inline references.
  4. Andreas Kienast commented on patch set 1 CR -2 08/05/19, 13:08

    Blocked until patch for master is handled properly in any way
  5. Christian Eßl commented on patch set 1 V +1 CR +1 10/09/19, 11:34

    Had this problem on a 8.7 project. This patch fixed the issue when localizing a full pagetree that also had inline relations with inline relations.
  6. Andreas Kienast voted on patch set 1 CR 0 01/27/20, 11:05

  7. Benni Mack commented on patch set 1 V +2 CR +2 01/27/20, 11:05

    straight backports.
  8. Benni Mack merged patch set 2 01/27/20, 11:05