Review main Merged

60728[BUGFIX] Migrate "Revert selection" of SelectCheckboxElement

Andreas Kienast CR +2 V +2 Easy +28 −18 updated 05/10/19, 14:47

Commit message

With #87324 parts of the FormEngine have been split into smaller,
maintainable parts. However, `SelectCheckboxElement` brings it's own
"Revert selection" implementation that has nothing in common with the
"Reset selection" field control used for select boxes.

The code is now rewritten to handle the revert on its own. Additionally,
another inline `onclick` handler was removed.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 69

  1. Andreas Kienast uploaded patch set 1 05/10/19, 08:43

  2. Andreas Kienast uploaded patch set 2 05/10/19, 08:54

  3. TYPO3com voted on patch set 1 V +1 05/10/19, 08:57 Completed build in 13m 39s on Fri, 10 May, 10:57 AM Test Summary: 47668 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33807

  4. TYPO3com voted on patch set 2 V +1 05/10/19, 09:07 Completed build in 12m 33s on Fri, 10 May, 11:07 AM Test Summary: 47670 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33808

  5. Andreas Kienast updated the commit message in patch set 3 05/10/19, 14:18

  6. Frank Nägler voted on patch set 3 V +1 CR +1 05/10/19, 14:26

  7. TYPO3com voted on patch set 3 V +1 05/10/19, 14:32 Completed build in 14m 15s on Fri, 10 May, 04:32 PM Test Summary: 47670 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33814

  8. Andreas Kienast voted on patch set 3 V +2 CR +2 05/10/19, 14:47

  9. Andreas Kienast merged patch set 4 05/10/19, 14:47