Review main Merged

60732[TASK] Prepare core tests for phpunit v8

Anja Leichsenring CR +2 V +2 Expert +1041 −854 updated 05/15/19, 06:53

Commit message

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 408

Show 388 more files

Review log 1824

  1. Anja Leichsenring uploaded patch set 1 05/11/19, 18:11

  2. TYPO3com voted on patch set 1 V -1 05/11/19, 18:11 Completed build in 16s on Sat, 11 May, 08:11 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33823

  3. Anja Leichsenring uploaded patch set 2 05/11/19, 18:27

  4. TYPO3com voted on patch set 2 V -1 05/11/19, 18:27 Completed build in 38s on Sat, 11 May, 08:27 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33824

  5. Anja Leichsenring uploaded patch set 3 05/11/19, 18:30

  6. TYPO3com voted on patch set 3 V -1 05/11/19, 18:30 Completed build in 37s on Sat, 11 May, 08:30 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33825

  7. Anja Leichsenring uploaded patch set 4 05/11/19, 18:37

  8. TYPO3com voted on patch set 4 V -1 05/11/19, 18:52 Completed build in 15m 09s on Sat, 11 May, 08:52 PM Test Summary: 10 of 48063 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33826

  9. Anja Leichsenring uploaded patch set 5 05/11/19, 19:26

  10. TYPO3com voted on patch set 5 V +1 05/11/19, 19:49 Completed build in 22m 08s on Sat, 11 May, 09:49 PM Test Summary: 47670 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33827

  11. Oliver Klee commented on patch set 5 05/12/19, 16:50

    PreviewModuleTest.php:27

    Why this change?

    DatabaseUniqueUidNewRowTest.php:32

    Why this change? Isn't the parent method empty?
  12. Anja Leichsenring commented on patch set 5 05/13/19, 19:18

    PreviewModuleTest.php:27 Reply

    because the receiving method defines the parameter as string. The test fails, because getTimestamp() returns integer.

    DatabaseUniqueUidNewRowTest.php:32 Reply

    first, it is not empty. second, even if it were - who guarantees it stays that way? This is method extension, parent has to be called in order to ensure clean environment reset for example.
  13. Georg Ringer commented on patch set 5 05/14/19, 05:36

    it would be easier to review if you don't mix the return type :void stuff into this change...
  14. Anja Leichsenring commented on patch set 5 05/14/19, 06:20

    > Patch Set 5: > > it would be easier to review if you don't mix the return type :void stuff into this change... phpunit v8 throws warnings if the return type does not match the parent implementation. So this is an essential part of the change.
  15. Andreas Kienast voted on patch set 5 V +1 CR +1 05/14/19, 06:36

  16. Oliver Klee voted on patch set 5 CR +1 05/14/19, 09:12

  17. Frank Nägler commented on patch set 5 CR -1 05/14/19, 21:08

    some small remarks

    AuthenticationServiceTest.php:59

    I am not sure about this change, e.g. the int cast will change an empty result value to 0.

    DatabaseSessionBackendTest.php:77

    same here, the int cast

    LogRecordTest.php:173

    that's a bit confusing, please let the (string) cast in the assert method instead of casting in the line before (as it was before this change).

    ExtensionUtilityTest.php:367

    this is a change of behavior for the test case. now the typeConverterClassName must be the first one.
  18. Anja Leichsenring commented on patch set 5 05/15/19, 06:08

    AuthenticationServiceTest.php:59 Reply

    which will still be save, as the test cares about non-deleted users. So the only setting that matters would be deleted = 1.

    DatabaseSessionBackendTest.php:77 Reply

    sqlite and postgres return strings, mysql returns int. How to handle?

    LogRecordTest.php:173 Reply Unresolved

    change it if it matters to you. Makes no difference in terms of the test.

    ExtensionUtilityTest.php:367 Reply

    it is, and thanks this being a unit test starting fresh, we can savely assume it is the first and only entry.
  19. Frank Nägler commented on patch set 6 05/15/19, 06:35

    Published edit on patch set 5.
  20. Frank Nägler commented on patch set 6 05/15/19, 06:35

    AuthenticationServiceTest.php:59 Reply

    Ack

    DatabaseSessionBackendTest.php:77 Reply

    Ack

    ExtensionUtilityTest.php:367 Reply

    Ack
  21. Frank Nägler voted on patch set 6 V +1 CR +1 05/15/19, 06:36

  22. TYPO3com voted on patch set 6 V +1 05/15/19, 06:48 Completed build in 13m 21s on Wed, 15 May, 08:48 AM Test Summary: 47686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33854

  23. Andreas Kienast voted on patch set 6 V +2 CR +2 05/15/19, 06:53

  24. Andreas Kienast merged patch set 7 05/15/19, 06:53