60735[BUGFIX] Normalize file path in PharStreamWrapperInterceptor
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1820
-
Susi Moog uploaded patch set 1 05/13/19, 06:29
-
TYPO3com voted on patch set 1 V -1 05/13/19, 06:41 Completed build in 12m 24s on Mon, 13 May, 08:41 AM Test Summary: 47685 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33836
-
TYPO3com voted on patch set 1 V +1 05/13/19, 07:06 Completed build in 49m 45s on Mon, 13 May, 09:06 AM Test Summary: 47685 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33836
-
Andreas Kienast voted on patch set 1 CR +1 05/13/19, 07:19
-
Kevin Meckl voted on patch set 1 CR +1 05/13/19, 07:33
-
Oliver Hader commented on patch set 1 05/13/19, 08:18
Upstream change https://github.com/TYPO3/phar-stream-wrapper/pull/36 -
Rudy Gnodde voted on patch set 1 CR +1 05/13/19, 10:44
-
Richard Haeser voted on patch set 1 CR +1 05/13/19, 11:07
-
Markus Klein voted on patch set 1 CR +1 05/13/19, 11:33
-
Oliver Hader voted on patch set 1 CR +1 05/13/19, 12:33
-
Susi Moog commented on patch set 1 05/14/19, 07:24
testing hint (how I tested): use the t3g google ads extension from TER, click on one of the new backend modules: "explodes". probably works with all other extensions with bundled dependencies, too. -
Oliver Klee voted on patch set 1 CR +1 05/14/19, 09:12
-
Tymoteusz Motylewski commented on patch set 1 05/14/19, 11:03
PharStreamWrapperInterceptor.php:57Will this change be still needed after this fix in phar-stream-wrapper? https://github.com/TYPO3/phar-stream-wrapper/commit/05895d9518a2a08ce89441d871d1d842adc04a0d ? -
Susi Moog wrote 05/14/19, 12:36
Removed Code-Review+1 by Richard Haeser <richard@maxserv.com> -
Susi Moog commented on patch set 1 05/14/19, 12:36
With upstream this change won't directly happen I guess, however it's imho cleaner this way. -
Oliver Hader commented on patch set 1 05/14/19, 13:36
Upstream changes are done and released -
Benni Mack commented on patch set 1 05/15/19, 08:02
PharStreamWrapperInterceptor.php:57Reply Unresolvednope. -
Susi Moog abandoned the change 05/15/19, 11:26
this was also fixed by https://review.typo3.org/c/Packages/TYPO3.CMS/+/60739 with alias resolving. while I'd still say it's cleaner to not rely on the third party code to unify pathes, I'm abandoning now. -
Oliver Hader commented on patch set 1 05/15/19, 11:34
The typo3/phar-stream-wrapper aims to return normalized unix-style path names (which could have been mixed before). I don't see a point why it is cleaner not to do it in the upstream project... -
Susi Moog commented on patch set 1 05/15/19, 11:50
Both. I would do both. I think handing over different slash styles to a third party is kinda weird... But anyway works now.