Review main Abandoned

60735[BUGFIX] Normalize file path in PharStreamWrapperInterceptor

Susi Moog CR 0 V 0 Easy +1 −0 updated 05/15/19, 11:50

Commit message

To allow Windows file paths to be handled by the interceptor, the base
name of a file should be normalized to only contain forward slashes.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1820

  1. Susi Moog uploaded patch set 1 05/13/19, 06:29

  2. TYPO3com voted on patch set 1 V -1 05/13/19, 06:41 Completed build in 12m 24s on Mon, 13 May, 08:41 AM Test Summary: 47685 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33836

  3. TYPO3com voted on patch set 1 V +1 05/13/19, 07:06 Completed build in 49m 45s on Mon, 13 May, 09:06 AM Test Summary: 47685 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33836

  4. Andreas Kienast voted on patch set 1 CR +1 05/13/19, 07:19

  5. Kevin Meckl voted on patch set 1 CR +1 05/13/19, 07:33

  6. Oliver Hader commented on patch set 1 05/13/19, 08:18

  7. Rudy Gnodde voted on patch set 1 CR +1 05/13/19, 10:44

  8. Richard Haeser voted on patch set 1 CR +1 05/13/19, 11:07

  9. Markus Klein voted on patch set 1 CR +1 05/13/19, 11:33

  10. Oliver Hader voted on patch set 1 CR +1 05/13/19, 12:33

  11. Susi Moog commented on patch set 1 05/14/19, 07:24

    testing hint (how I tested): use the t3g google ads extension from TER, click on one of the new backend modules: "explodes". probably works with all other extensions with bundled dependencies, too.
  12. Oliver Klee voted on patch set 1 CR +1 05/14/19, 09:12

  13. Tymoteusz Motylewski commented on patch set 1 05/14/19, 11:03

    PharStreamWrapperInterceptor.php:57

    Will this change be still needed after this fix in phar-stream-wrapper? https://github.com/TYPO3/phar-stream-wrapper/commit/05895d9518a2a08ce89441d871d1d842adc04a0d ?
  14. Susi Moog wrote 05/14/19, 12:36

    Removed Code-Review+1 by Richard Haeser <richard@maxserv.com>
  15. Susi Moog commented on patch set 1 05/14/19, 12:36

    With upstream this change won't directly happen I guess, however it's imho cleaner this way.
  16. Oliver Hader commented on patch set 1 05/14/19, 13:36

    Upstream changes are done and released
  17. Benni Mack commented on patch set 1 05/15/19, 08:02

    PharStreamWrapperInterceptor.php:57 Reply Unresolved

    nope.
  18. Susi Moog abandoned the change 05/15/19, 11:26

    this was also fixed by https://review.typo3.org/c/Packages/TYPO3.CMS/+/60739 with alias resolving. while I'd still say it's cleaner to not rely on the third party code to unify pathes, I'm abandoning now.
  19. Oliver Hader commented on patch set 1 05/15/19, 11:34

    The typo3/phar-stream-wrapper aims to return normalized unix-style path names (which could have been mixed before). I don't see a point why it is cleaner not to do it in the upstream project...
  20. Susi Moog commented on patch set 1 05/15/19, 11:50

    Both. I would do both. I think handing over different slash styles to a third party is kinda weird... But anyway works now.