Review main Merged

60739[BUGFIX] Avoid realpath resolving in PharStreamWrapperInterceptor

Oliver Hader CR +2 V +2 Easy +2 −1 updated 05/15/19, 07:10

Commit message

Given that e.g. public/typo3conf/ext/my_extension is symlinked to
packages/my_extension, PharStreamWrapper denies invocation since
realpath is resolved.

For the specific PharStreamWrapperInterceptor it is okay to avoid
realpath resolving.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Kevin Meckl +1
    • Markus Klein +1
    • Richard Haeser +1
    • Mathias Brodala +1
    • Thomas Löffler +1
    • Rudy Gnodde +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
    • Mathias Brodala +1
    • Thomas Löffler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1516

  1. Oliver Hader uploaded patch set 1 05/13/19, 08:44

  2. TYPO3com voted on patch set 1 V +1 05/13/19, 09:00 Completed build in 16m 06s on Mon, 13 May, 11:00 AM Test Summary: 47686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33841

  3. Oliver Klee voted on patch set 1 CR +1 05/13/19, 09:39

  4. Mathias Brodala commented on patch set 1 V +1 CR +1 05/13/19, 09:55

  5. Thomas Löffler voted on patch set 1 V +1 CR +1 05/13/19, 10:28

  6. Rudy Gnodde voted on patch set 1 CR +1 05/13/19, 10:44

  7. Kevin Meckl voted on patch set 1 CR +1 05/13/19, 10:57

  8. Richard Haeser voted on patch set 1 CR +1 05/13/19, 11:08

  9. Markus Klein commented on patch set 1 05/13/19, 11:36

    PharStreamWrapperInterceptor.php:53

    If this parameter is not set, internally ASSERT_INTERNAL_INVOCATION is used as well. Since there is no documentation about this flag in the code, I'm asking whether this would be needed here too?
  10. Benni Mack commented on patch set 1 05/14/19, 15:16

    PharStreamWrapperInterceptor.php:53 Reply

    very good question, maybe Olly - can you shed some light on this?
  11. Oliver Hader commented on patch set 1 05/14/19, 15:46

    PharStreamWrapperInterceptor.php:53 Reply

  12. Markus Klein commented on patch set 1 05/14/19, 18:12

    PharStreamWrapperInterceptor.php:53 Reply

    Ack
  13. Markus Klein voted on patch set 1 V +1 CR +1 05/14/19, 18:49

  14. Andreas Kienast voted on patch set 1 V +1 CR +1 05/15/19, 07:08

  15. Andreas Kienast voted on patch set 1 V +2 CR +2 05/15/19, 07:10

  16. Andreas Kienast merged patch set 2 05/15/19, 07:10