Review main Merged

60752[FEATURE] Separately enable / disable "Add media by URL" and "Select & upload files"

Philipp Parzer CR +2 V +2 Normal +51 −9 updated 08/29/19, 08:07

Commit message

A new appearance property "fileByUrlAllowed" is used to separately enable / disable
the buttons "Add media by URL" and "Select & upload files".
fileUploadAllowed = 0 now only hides the button "Select & upload files"
fileByUrlAllowed = 0 now hides the button "Add media by URL"
if "elementBrowserType" is set to "file" both values are true by default

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Markus Klein +1
    • Guido Schmechel +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Guido Schmechel +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2026

Show 1 earlier messages
  1. Philipp Parzer uploaded patch set 1 05/14/19, 12:39

  1. TYPO3com voted on patch set 1 V +1 05/14/19, 12:52 Completed build in 12m 50s on Tue, 14 May, 02:52 PM Test Summary: 47686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33849

  2. Guido Schmechel commented on patch set 1 05/15/19, 09:28

  3. Guido Schmechel commented on patch set 1 05/15/19, 09:31

    The commit message headline could also be a bit more concise for the changelog. Otherwise: Great that you work on this topic. I will gladly review it.
  4. Philipp Parzer uploaded patch set 2 05/15/19, 11:43

  5. TYPO3com voted on patch set 2 V +1 05/15/19, 12:01 Completed build in 17m 13s on Wed, 15 May, 02:01 PM Test Summary: 47599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33871

  6. Markus Klein commented on patch set 2 05/15/19, 12:29

    Unresolved

    this should be at the very bottom together with the change-id
  7. Markus Klein updated the commit message in patch set 3 05/15/19, 12:30

  8. Tymoteusz Motylewski commented on patch set 3 05/15/19, 12:32

    Feature-84250-SeparatlyEnableDisableAddMediaByURLAndSelectUploadFiles.rst:14 Unresolved

    please mention what are the default values of these settings.
  9. Guido Schmechel commented on patch set 3 05/15/19, 12:42

    Unresolved

    "Separately"
  10. TYPO3com voted on patch set 3 V +1 05/15/19, 12:43 Completed build in 12m 42s on Wed, 15 May, 02:43 PM Test Summary: 47599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33872

  11. Philipp Parzer uploaded patch set 4 05/15/19, 13:05

  12. TYPO3com voted on patch set 4 V +1 05/15/19, 13:19 Completed build in 13m 29s on Wed, 15 May, 03:19 PM Test Summary: 47599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33874

  13. Tymoteusz Motylewski commented on patch set 4 05/16/19, 10:16

    Feature-84250-SeparatelyEnableDisableAddMediaByURLAndSelectUploadFiles.rst:15 Unresolved

    can this property be used with different elementBrowserType's ?
  14. Philipp Parzer uploaded patch set 5 08/02/19, 18:50

  15. TYPO3com voted on patch set 5 V +1 08/02/19, 19:00 Completed build in 09m 58s on Fri, 2 Aug, 07:00 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35487

  16. Georg Ringer voted on patch set 5 V +1 CR +1 08/02/19, 19:24

  17. Cristian Buja voted on patch set 5 V +1 08/02/19, 20:58

  18. Markus Klein voted on patch set 5 CR +1 08/05/19, 07:32

  19. Anja Leichsenring commented on patch set 6 08/23/19, 14:10

    Published edit on patch set 5.
  20. Anja Leichsenring voted on patch set 6 V +1 CR +1 08/23/19, 14:10

  21. TYPO3com voted on patch set 6 V +1 08/23/19, 14:20 Completed build in 10m 10s on Fri, 23 Aug, 02:20 PM Test Summary: 47227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35805

  22. Markus Klein voted on patch set 6 CR +1 08/23/19, 17:32

  23. Guido Schmechel voted on patch set 6 V +1 CR +1 08/27/19, 21:16

  24. Daniel Goerz voted on patch set 6 V +2 CR +2 08/29/19, 08:07

  25. Daniel Goerz merged patch set 7 08/29/19, 08:07