Review 9.5 Merged

60753[BUGFIX] Do not query row twice if not necessary

Markus Klein CR +2 V +2 Easy +5 −1 updated 08/05/19, 12:54

Commit message

If the live record is the same as the one passed in as parameter
it is not necessary to fetch the record again from database.
Simply use the incoming data.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Oliver Klee +1
    • Guido Schmechel +1
    • Anja Leichsenring +1
    • Tymoteusz Motylewski +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1011

  1. Markus Klein uploaded patch set 1 05/14/19, 15:42

  2. TYPO3com voted on patch set 1 V +1 05/14/19, 15:54 Completed build in 11m 43s on Tue, 14 May, 05:54 PM Test Summary: 50341 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-701

  3. Guido Schmechel voted on patch set 1 CR +1 05/14/19, 16:26

  4. Oliver Klee commented on patch set 1 05/14/19, 19:09

    Master is not affected?
  5. Oliver Klee voted on patch set 1 CR +1 05/14/19, 19:09

  6. Markus Klein commented on patch set 1 05/14/19, 20:58

    This is a v8 upgrade wizard that does not exist anymore in v10
  7. Tymoteusz Motylewski voted on patch set 1 CR +1 05/20/19, 21:15

  8. Anja Leichsenring voted on patch set 1 V +1 CR +1 08/02/19, 15:22

  9. Frank Nägler voted on patch set 1 CR +1 08/05/19, 12:51

  10. Frank Nägler voted on patch set 1 V +2 CR +2 08/05/19, 12:54

  11. Frank Nägler merged patch set 2 08/05/19, 12:54