Review main Merged

60754[TASK] Upgrade typo3/phar-stream-wrapper to v3.1.2

Oliver Hader CR +2 V +2 Easy +17 −10 updated 05/15/19, 10:34

Commit message

https://github.com/TYPO3/phar-stream-wrapper/releases/tag/v3.1.2

* #34: Normalize resolved Windows path to Unix-style
* #42: Avoid analysing non-phar files on alias resolving
* #40: Add Windows tests using AppVeyor
* #33: Add alternative mime-type resolving (without ext-fileinfo)

composer require typo3/phar-stream-wrapper:^3.1.2

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 68

  1. Oliver Hader uploaded patch set 1 05/14/19, 22:21

  2. TYPO3com voted on patch set 1 V +1 05/14/19, 22:34 Completed build in 13m 08s on Wed, 15 May, 12:34 AM Test Summary: 47686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33853

  3. Andreas Kienast commented on patch set 1 V +1 CR +1 05/15/19, 07:12

    Can't test this in a meaningful way, as I don't run on Windows. Everything is _still_ fine after applying the patch, though
  4. Andreas Kienast voted on patch set 1 V 0 05/15/19, 07:13

  5. Benni Mack uploaded patch set 2 05/15/19, 10:18

  6. TYPO3com voted on patch set 2 V +1 05/15/19, 10:32 Completed build in 14m 10s on Wed, 15 May, 12:32 PM Test Summary: 47686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33866

  7. Benni Mack voted on patch set 2 V +2 CR +2 05/15/19, 10:34

  8. Benni Mack merged patch set 3 05/15/19, 10:34