Review main Merged

60757[TASK] Switch functional tests to site handling

Benni Mack CR +2 V +2 Hard +502 −160 updated 05/15/19, 10:25

Commit message

All functional tests that run a frontend subrequest
should be tested against Site Handling, as the
PseudoSite Handling is about to removed.

This patch is actually a precursor to make sure
that all tests work with site handling now.

The AbstractDataHandlerActionTestCase adds
e site configuration on each setUp(). This
way, all DataHandler-related tests are running
with a Site configuration of three languages.

In addition, when "localizing" something,
a translated page needs to exist, so most
DataHandler related changes add this functionality.

For some DataHandler tests, the SiteConfiguration
is adapted to define the previous behavior
built in TypoScript.

One addition in PageResolver is made:
If an GET / POST &id query parameter is given,
and it is not accessible, it will fail now.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 60

Show 40 more files

Review log 710

  1. Benni Mack uploaded patch set 1 05/15/19, 08:01

  2. TYPO3com voted on patch set 1 V -1 05/15/19, 08:15 Completed build in 13m 39s on Wed, 15 May, 10:15 AM Test Summary: 59 of 47992 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33859

  3. Benni Mack uploaded patch set 2 05/15/19, 08:54

  4. Benni Mack updated the commit message in patch set 3 05/15/19, 08:59

  5. TYPO3com voted on patch set 2 V +1 05/15/19, 09:10 Completed build in 15m 51s on Wed, 15 May, 11:10 AM Test Summary: 47599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33862

  6. TYPO3com voted on patch set 3 V +1 05/15/19, 09:11 Completed build in 11m 55s on Wed, 15 May, 11:11 AM Test Summary: 47599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33863

  7. Andreas Kienast voted on patch set 3 V +1 CR +1 05/15/19, 09:21

  8. Oliver Hader voted on patch set 3 CR +1 05/15/19, 10:07

  9. Georg Ringer voted on patch set 3 V +2 CR +2 05/15/19, 10:25

  10. Georg Ringer merged patch set 4 05/15/19, 10:25