60758[BUGFIX] Fix record preview
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Tymoteusz Motylewski +1
- Oliver Hader +1
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1316
-
Daniel Dorndorf uploaded patch set 1 05/15/19, 08:25
-
Benni Mack updated the commit message in patch set 2 05/15/19, 08:37
-
TYPO3com voted on patch set 1 V +1 05/15/19, 08:39 Completed build in 13m 47s on Wed, 15 May, 10:39 AM Test Summary: 47685 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33860
-
Manuel Selbach voted on patch set 2 CR +1 05/15/19, 08:40
-
Benni Mack commented on patch set 2 V +1 CR +1 05/15/19, 08:46
a simple parantethesis "()" around the "??" evaluation would have worked too. Crazy. https://3v4l.org/Qq5X7 -
TYPO3com voted on patch set 2 V +1 05/15/19, 08:50 Completed build in 12m 52s on Wed, 15 May, 10:50 AM Test Summary: 47686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33861
-
Andreas Kienast voted on patch set 2 CR +1 05/15/19, 08:50
-
Benni Mack uploaded patch set 3 05/15/19, 09:04
-
Benni Mack voted on patch set 3 V +1 CR +1 05/15/19, 09:04
-
Andreas Kienast voted on patch set 3 V +1 CR +1 05/15/19, 09:05
-
Tymoteusz Motylewski voted on patch set 3 CR +1 05/15/19, 09:10
-
TYPO3com voted on patch set 3 V +1 05/15/19, 09:18 Completed build in 14m 01s on Wed, 15 May, 11:18 AM Test Summary: 47684 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33864
-
Daniel Dorndorf commented on patch set 3 05/15/19, 09:22
> Patch Set 2: Verified+1 Code-Review+1 > > a simple parantethesis "()" around the "??" evaluation would have worked too. Crazy. > > https://3v4l.org/Qq5X7 paranthesis gave me the same result, I had to explicity move it out of the if -
Andreas Kienast voted on patch set 3 V +2 CR +2 05/15/19, 09:22
-
Andreas Kienast merged patch set 4 05/15/19, 09:23
-
Oliver Hader voted on patch set 4 CR +1 05/15/19, 09:31