Review main Merged

60758[BUGFIX] Fix record preview

Daniel Dorndorf CR +2 V +2 Easy +1 −1 updated 05/15/19, 09:31

Commit message

A wrong evaluation of the null coalesce
assignment (?? is evaluted and && later-on),
the if() condition was always true for
any previews of records with versioning
enabled.

The Backend API is used instead.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Tymoteusz Motylewski +1
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1316

  1. Daniel Dorndorf uploaded patch set 1 05/15/19, 08:25

  2. Benni Mack updated the commit message in patch set 2 05/15/19, 08:37

  3. TYPO3com voted on patch set 1 V +1 05/15/19, 08:39 Completed build in 13m 47s on Wed, 15 May, 10:39 AM Test Summary: 47685 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33860

  4. Manuel Selbach voted on patch set 2 CR +1 05/15/19, 08:40

  5. Benni Mack commented on patch set 2 V +1 CR +1 05/15/19, 08:46

    a simple parantethesis "()" around the "??" evaluation would have worked too. Crazy. https://3v4l.org/Qq5X7
  6. TYPO3com voted on patch set 2 V +1 05/15/19, 08:50 Completed build in 12m 52s on Wed, 15 May, 10:50 AM Test Summary: 47686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33861

  7. Andreas Kienast voted on patch set 2 CR +1 05/15/19, 08:50

  8. Benni Mack uploaded patch set 3 05/15/19, 09:04

  9. Benni Mack voted on patch set 3 V +1 CR +1 05/15/19, 09:04

  10. Andreas Kienast voted on patch set 3 V +1 CR +1 05/15/19, 09:05

  11. Tymoteusz Motylewski voted on patch set 3 CR +1 05/15/19, 09:10

  12. TYPO3com voted on patch set 3 V +1 05/15/19, 09:18 Completed build in 14m 01s on Wed, 15 May, 11:18 AM Test Summary: 47684 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33864

  13. Daniel Dorndorf commented on patch set 3 05/15/19, 09:22

    > Patch Set 2: Verified+1 Code-Review+1 > > a simple parantethesis "()" around the "??" evaluation would have worked too. Crazy. > > https://3v4l.org/Qq5X7 paranthesis gave me the same result, I had to explicity move it out of the if
  14. Andreas Kienast voted on patch set 3 V +2 CR +2 05/15/19, 09:22

  15. Andreas Kienast merged patch set 4 05/15/19, 09:23

  16. Oliver Hader voted on patch set 4 CR +1 05/15/19, 09:31