60769[!!!][TASK] Streamline TimeTracker global information
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Andreas Kienast +1
-
Verified V +2 Done
- Georg Ringer +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 9
- typo3/sysext/core/Classes/Core/SystemEnvironmentBuilder.php+0 −3
- typo3/sysext/core/Classes/TimeTracker/TimeTracker.php2+32 −18
- typo3/sysext/core/Documentation/Changelog/master/Breaking-88498-GlobalDataForTimeTrackerStatisticsRemoved.rstnew+44 −0
- typo3/sysext/core/Tests/Unit/Core/SystemEnvironmentBuilderTest.php+0 −20
- typo3/sysext/core/Tests/Unit/TimeTracker/TimeTrackerTest.php+7 −43
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+2 −11
- typo3/sysext/frontend/Classes/Middleware/TimeTrackerInitialization.php+29 −4
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+20 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayGlobalMatcher.php+5 −0
Review log 1116
-
Benni Mack uploaded patch set 1 05/16/19, 12:17
-
TYPO3com voted on patch set 1 V +1 05/16/19, 12:29 Completed build in 12m 11s on Thu, 16 May, 02:29 PM Test Summary: 46497 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33896
-
Benni Mack uploaded patch set 2 06/05/19, 21:13
-
TYPO3com voted on patch set 2 V +1 06/05/19, 21:26 Completed build in 13m 18s on Wed, 5 Jun, 11:26 PM Test Summary: 46486 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34212
-
Oliver Klee commented on patch set 2 06/05/19, 21:27
typo: initialzied -> initialized -
Oliver Klee commented on patch set 2 06/05/19, 21:28
TimeTracker.php:156Can we add a :void return type declaration while the declaration is updated? -
Benni Mack uploaded patch set 3 06/07/19, 05:39
-
TYPO3com voted on patch set 3 V +1 06/07/19, 05:52 Completed build in 12m 53s on Fri, 7 Jun, 07:52 AM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34234
-
Andreas Kienast commented on patch set 3 06/07/19, 08:34
TimeTracker.php:333UnresolvedThis might fail since `getMilliseconds()` returns a float due to `round()` -
Andreas Kienast uploaded patch set 4 06/07/19, 08:34
-
Andreas Kienast uploaded patch set 5 06/07/19, 08:40
-
TYPO3com voted on patch set 4 V +1 06/07/19, 08:44 Completed build in 10m 01s on Fri, 7 Jun, 10:44 AM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34239
-
TYPO3com voted on patch set 5 V +1 06/07/19, 08:53 Completed build in 13m 01s on Fri, 7 Jun, 10:53 AM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34240
-
Andreas Kienast voted on patch set 5 V +1 CR +1 06/07/19, 08:54
-
Georg Ringer voted on patch set 5 V +2 CR +2 06/08/19, 03:52
-
Georg Ringer merged patch set 6 06/08/19, 03:52