Review main Merged Breaking

60769[!!!][TASK] Streamline TimeTracker global information

Benni Mack CR +2 V +2 Normal +139 −99 updated 06/08/19, 03:52

Commit message

This patch removes unused variables:

$GLOBALS['TYPO3_MISC']['microtime_BE_USER_start']
$GLOBALS['TYPO3_MISC']['microtime_BE_USER_end']
$GLOBALS['TYPO3_MISC']['microtime_end']
$GLOBALS['TYPO3_MISC']['microtime_start']

are replaced by properly using
- TimeTracker->start()
- TimeTracker->finish() (new method)

to encapsulate the logic into the main method.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 1116

  1. Benni Mack uploaded patch set 1 05/16/19, 12:17

  2. TYPO3com voted on patch set 1 V +1 05/16/19, 12:29 Completed build in 12m 11s on Thu, 16 May, 02:29 PM Test Summary: 46497 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33896

  3. Benni Mack uploaded patch set 2 06/05/19, 21:13

  4. TYPO3com voted on patch set 2 V +1 06/05/19, 21:26 Completed build in 13m 18s on Wed, 5 Jun, 11:26 PM Test Summary: 46486 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34212

  5. Oliver Klee commented on patch set 2 06/05/19, 21:27

    typo: initialzied -> initialized
  6. Oliver Klee commented on patch set 2 06/05/19, 21:28

    TimeTracker.php:156

    Can we add a :void return type declaration while the declaration is updated?
  7. Benni Mack uploaded patch set 3 06/07/19, 05:39

  8. TYPO3com voted on patch set 3 V +1 06/07/19, 05:52 Completed build in 12m 53s on Fri, 7 Jun, 07:52 AM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34234

  9. Andreas Kienast commented on patch set 3 06/07/19, 08:34

    TimeTracker.php:333 Unresolved

    This might fail since `getMilliseconds()` returns a float due to `round()`
  10. Andreas Kienast uploaded patch set 4 06/07/19, 08:34

  11. Andreas Kienast uploaded patch set 5 06/07/19, 08:40

  12. TYPO3com voted on patch set 4 V +1 06/07/19, 08:44 Completed build in 10m 01s on Fri, 7 Jun, 10:44 AM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34239

  13. TYPO3com voted on patch set 5 V +1 06/07/19, 08:53 Completed build in 13m 01s on Fri, 7 Jun, 10:53 AM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34240

  14. Andreas Kienast voted on patch set 5 V +1 CR +1 06/07/19, 08:54

  15. Georg Ringer voted on patch set 5 V +2 CR +2 06/08/19, 03:52

  16. Georg Ringer merged patch set 6 06/08/19, 03:52