60770[BUGFIX] Allow leading zeros in croncommand
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Oliver Klee +1
- Guido Schmechel +1
- Anja Leichsenring +1
- Jörg Bösche +1
-
Verified V +2 Done
- Susi Moog +2
- Guido Schmechel +1
- Anja Leichsenring +1
- Jörg Bösche +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 2835
Show 710 earlier messages
-
Tomas Norre Mikkelsen uploaded patch set 1 05/16/19, 15:12
-
Tomas Norre Mikkelsen updated the commit message in patch set 2 05/16/19, 15:13
-
TYPO3com voted on patch set 1 V +1 05/16/19, 15:27 Completed build in 14m 56s on Thu, 16 May, 05:27 PM Test Summary: 46509 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33897
-
TYPO3com voted on patch set 2 V +1 05/16/19, 15:28 Completed build in 14m 24s on Thu, 16 May, 05:28 PM Test Summary: 46509 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33898
-
Oliver Klee commented on patch set 2 05/16/19, 16:12
NormalizeCommandTest.php:57We should also have tests for numbers like "08" to make sure they will not be interpreted as octal numbers. -
Tomas Norre Mikkelsen commented on patch set 2 05/16/19, 16:49
NormalizeCommand.php:184ReplyI thought that too.. But looking at the results the tests producesses, I would say no. The question is if it is the can be MathUtility::canBeInterpretedAsInteger should be adjusted instead?NormalizeCommandTest.php:57ReplyValid point, will update the tests. -
Tomas Norre Mikkelsen uploaded patch set 3 05/16/19, 16:51
-
TYPO3com voted on patch set 3 V +1 05/16/19, 17:03 Completed build in 11m 56s on Thu, 16 May, 07:03 PM Test Summary: 46513 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33899
-
Mathias Brodala commented on patch set 3 CR -1 05/17/19, 07:05
NormalizeCommand.php:186Can we avoid the double conversion here? Also what about '00'? This would currently lead to the exception below. -
Tomas Norre Mikkelsen commented on patch set 3 05/17/19, 07:25
NormalizeCommand.php:186ReplyYou're right about the '00' didn't think about that. Will have to think about how to do this better.
-
Mathias Brodala commented on patch set 3 05/17/19, 07:35
NormalizeCommand.php:186Reply UnresolvedA simple check if the 1st character is a "0" and the string length is 2 should be enough. If yes, then use the 2nd character as int. -
Andreas Kienast commented on patch set 3 05/17/19, 09:18
^NormalizeCommandTest.php:58Please add a test for the mentioned 00 case. -
Anja Leichsenring commented on patch set 3 05/17/19, 09:47
not for 8.7, please. This is nothing critical. -
Tomas Norre Mikkelsen commented on patch set 3 05/17/19, 11:42
> Patch Set 3: > > not for 8.7, please. This is nothing critical. Will Corret that in my next patch set.NormalizeCommandTest.php:58ReplyWill add that with my next patch set. -
Tomas Norre Mikkelsen uploaded patch set 4 05/17/19, 11:54
-
TYPO3com voted on patch set 4 V -1 05/17/19, 11:54 Completed build in 11s on Fri, 17 May, 01:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33911
-
Tomas Norre Mikkelsen commented on patch set 4 05/17/19, 11:55
> Patch Set 4: Verified-1 > > Completed build in 11s on Fri, 17 May, 01:54 PM > Test Summary: No tests found > Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33911 What can I do about this?NormalizeCommandTest.php:58ReplyDone -
Guido Schmechel commented on patch set 4 05/17/19, 12:00
-
Oliver Klee commented on patch set 4 05/17/19, 12:00
NormalizeCommand.php:185The space before the last ) needs to go away to fix the build failure. -
Tomas Norre Mikkelsen uploaded patch set 5 05/17/19, 12:01
-
TYPO3com commented on patch set 5 05/17/19, 12:02 Completed build in 12s on Fri, 17 May, 02:02 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33912
-
Tomas Norre Mikkelsen commented on patch set 5 05/17/19, 12:02
> Patch Set 4: > > Maybe this: https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/Appendix/CglFixMyCommit.html Thanks -
Tomas Norre Mikkelsen commented on patch set 5 05/17/19, 12:04
Didn't help -
Tomas Norre Mikkelsen commented on patch set 5 05/17/19, 12:05
My bad.. -
Tomas Norre Mikkelsen uploaded patch set 6 05/17/19, 12:05
-
TYPO3com voted on patch set 6 V +1 05/17/19, 12:16 Completed build in 10m 11s on Fri, 17 May, 02:16 PM Test Summary: 46517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33913
-
Mathias Brodala voted on patch set 6 CR +1 05/17/19, 12:38
-
Oliver Klee commented on patch set 7 05/17/19, 15:08
Published edit on patch set 6. -
Oliver Klee voted on patch set 7 CR +1 05/17/19, 15:08
-
TYPO3com voted on patch set 7 V +1 05/17/19, 15:20 Completed build in 12m 16s on Fri, 17 May, 05:20 PM Test Summary: 46517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33916
-
Anja Leichsenring voted on patch set 7 V +1 CR +1 05/19/19, 07:37
-
Guido Schmechel voted on patch set 7 V +1 CR +1 05/19/19, 12:09
-
Jörg Bösche voted on patch set 7 V +1 CR +1 05/19/19, 20:16
-
Susi Moog voted on patch set 7 V +2 CR +2 05/24/19, 12:56
-
Susi Moog merged patch set 8 05/24/19, 12:56
NormalizeCommand.php:184