Review main Abandoned

60776[WIP][TASK] Add test for invalid fluid tags

Benni Mack CR 0 V 0 Easy +38 −0 updated 06/05/19, 10:14

Commit message

Fluid has some weird behavior in PHP 7.3.5,
and a test actually should prove this.

Review

  • Code review CR 0
  • Verified V 0

Files 2

Review log 34

  1. Benni Mack uploaded patch set 1 05/17/19, 19:42

  2. TYPO3com voted on patch set 1 V +1 05/17/19, 19:53 Completed build in 11m 47s on Fri, 17 May, 09:53 PM Test Summary: 46508 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33917

  3. Anja Leichsenring commented on patch set 1 05/19/19, 06:54

    StandaloneTemplateViewTest.php:30 Unresolved

    please use $this->assertStringContainsString(). AssertContains with string input is deprecated with phpunit v8.
  4. Benni Mack abandoned the change 06/05/19, 10:14