Review 9.5 Abandoned

60777[TASK] Prepare core tests for phpunit v8

Anja Leichsenring CR 0 V 0 Expert +1232 −952 updated 06/12/19, 07:38

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 449

Show 429 more files

Review log 813

  1. Anja Leichsenring uploaded patch set 1 05/18/19, 12:00

  2. TYPO3com voted on patch set 1 V -1 05/18/19, 12:00 Completed build in 15s on Sat, 18 May, 02:00 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-714

  3. Anja Leichsenring uploaded patch set 2 05/18/19, 12:04

  4. TYPO3com voted on patch set 2 V -1 05/18/19, 12:04 Completed build in 12s on Sat, 18 May, 02:04 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-715

  5. Anja Leichsenring uploaded patch set 3 05/18/19, 12:09

  6. TYPO3com voted on patch set 3 V -1 05/18/19, 12:10 Completed build in 39s on Sat, 18 May, 02:10 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-716

  7. Anja Leichsenring uploaded patch set 4 05/18/19, 12:11

  8. TYPO3com voted on patch set 4 V +1 05/18/19, 12:29 Completed build in 18m 10s on Sat, 18 May, 02:29 PM Test Summary: 50325 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-717

  9. Jörg Bösche commented on patch set 4 CR +1 05/19/19, 20:25

    450 files... yeah. ;-) Looks good to me.
  10. Anja Leichsenring rebased onto patch set 5 06/08/19, 10:00

  11. TYPO3com voted on patch set 5 V +1 06/08/19, 10:15 Completed build in 14m 24s on Sat, 8 Jun, 12:14 PM Test Summary: 50377 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-769

  12. Susi Moog commented on patch set 5 06/12/19, 05:14

    reviewed first 200 files.

    AuthenticationServiceTest.php:59 Unresolved

    remove the int cast? if it isn't returned as int either the assertion or something in the code is wrong.

    DatabaseSessionBackendTest.php:77 Unresolved

    see previous comment

    DatabaseSessionBackendTest.php:91 Unresolved

    see previous comment

    DatabaseSessionBackendTest.php:121 Unresolved

    see previous comment

    DatabaseSessionBackendTest.php:212 Unresolved

    see above

    DatabaseSessionBackendTest.php:233 Unresolved

    see above

    MailerTest.php:80 Unresolved

    this reads wrong in a test that's called `globalSettingsAreUsedIfNoSettingsAreInjected` - the point of the test seems to be that no settings are injected.
  13. Anja Leichsenring abandoned the change 06/12/19, 07:38

    TYPO3 v9 will not use phpunit v8.