Review main Merged

60778[BUGFIX] Remove superflous parameter that blocks the test

Anja Leichsenring CR +2 V +2 Easy +1 −1 updated 05/21/19, 13:36

Commit message

assertNotNull takes only one parameter, but due to a left over
from former refactoring, it got two, and the first one
was a static string. So the test actually did not test
what it was supposed to test.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Guido Schmechel +1
    • Tymoteusz Motylewski +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Anja Leichsenring uploaded patch set 1 05/18/19, 12:23

  2. TYPO3com voted on patch set 1 V +1 05/18/19, 12:40 Completed build in 14m 56s on Sat, 18 May, 02:40 PM Test Summary: 46505 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33918

  3. Guido Schmechel voted on patch set 1 CR +1 05/18/19, 12:45

  4. Tymoteusz Motylewski voted on patch set 1 V +1 CR +1 05/18/19, 16:25

  5. Oliver Klee voted on patch set 1 CR +1 05/18/19, 20:14

  6. Georg Ringer voted on patch set 1 V +2 CR +2 05/21/19, 13:36

  7. Georg Ringer merged patch set 2 05/21/19, 13:36