Review main Merged

60779[TASK] Update typo3/testing-framework, phpunit and codeception

Anja Leichsenring CR +2 V +2 Easy +3 −3 updated 05/20/19, 13:52

Commit message

commands:
	composer update typo3/testing-framework
	composer require --dev codeception/codeception:^3
	composer update codeception/codeception --with-dependencies

Leads to:
	typo3/testing-framework 5.0.9
	codeception/codeception: 3.0.0
	phpunit/phpunit: 8.1.5

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1218

  1. Anja Leichsenring uploaded patch set 1 05/18/19, 12:40

  2. Anja Leichsenring uploaded patch set 2 05/18/19, 12:56

  3. TYPO3com voted on patch set 1 V -1 05/18/19, 12:57 Completed build in 17m 25s on Sat, 18 May, 02:57 PM Test Summary: 46505 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33919

  4. TYPO3com voted on patch set 2 V +1 05/18/19, 13:34 Completed build in 31m 53s on Sat, 18 May, 03:34 PM Test Summary: 46505 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33920

  5. Anja Leichsenring commented on patch set 2 05/18/19, 13:44

    triggered a nightly for test: https://bamboo.typo3.com/browse/CORE-GTN-785
  6. Anja Leichsenring uploaded patch set 3 05/18/19, 15:17

  7. TYPO3com voted on patch set 3 V -1 05/18/19, 15:18 Completed build in 11s on Sat, 18 May, 05:18 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33921

  8. Anja Leichsenring uploaded patch set 4 05/18/19, 15:42

  9. TYPO3com voted on patch set 4 V -1 05/18/19, 15:42 Completed build in 11s on Sat, 18 May, 05:42 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33922

  10. Anja Leichsenring uploaded patch set 5 05/18/19, 15:47

  11. TYPO3com voted on patch set 5 V -1 05/18/19, 16:07 Completed build in 18m 34s on Sat, 18 May, 06:07 PM Test Summary: 20 of 46844 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33923

  12. Anja Leichsenring uploaded patch set 6 05/18/19, 17:01

  13. TYPO3com voted on patch set 6 V +1 05/18/19, 17:35 Completed build in 30m 34s on Sat, 18 May, 07:35 PM Test Summary: 46505 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33924

  14. Anja Leichsenring commented on patch set 6 05/18/19, 18:24

  15. Oliver Klee voted on patch set 6 CR +1 05/18/19, 20:14

  16. Georg Ringer voted on patch set 6 V +1 CR +1 05/20/19, 12:16

  17. Benni Mack voted on patch set 6 V +2 CR +2 05/20/19, 13:52

  18. Benni Mack merged patch set 7 05/20/19, 13:52