Review main Abandoned Breaking

60787[WIP][!!!][TASK] Remove t3ver_state=-1 (new placeholder version)

Benni Mack CR 0 V 0 Easy +7 −26 updated 06/05/19, 19:44

Commit message

If a new record gets created in a workspace, the workspaced(!)
records gets a "t3ver_state=-1" set. This information is not
necessary, as "t3ver_state=0" is sufficient in the same way to
find out if a record got modified or created.

In order to ease the pain with workspaces, we reduce the complexity
in various places by removing this placeholder speciality.

Since Doctrine DBAL is used natively, no need to change anything
for any extension developer, only the database values are modified.

An upgrade wizard (still missing) is updating t3ver_state=-1
to t3ver_state=0 records in a workspace.

ToDo:
- Add Update Wizard
- Migrate move placeholder information as well (and handle that in the upgrade wizard)
- Add RST
- Adapt tests

Review

  • Code review CR 0
  • Verified V 0

Files 8

Review log 34

  1. Benni Mack uploaded patch set 1 05/20/19, 20:39

  2. TYPO3com voted on patch set 1 V -1 05/20/19, 20:50 Completed build in 10m 53s on Mon, 20 May, 10:50 PM Test Summary: 363 of 46844 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33953

  3. Benni Mack commented on patch set 1 06/05/19, 06:20

    DataHandler.php:1121 Unresolved

    I guess that's the record we should completely remove.
  4. Benni Mack abandoned the change 06/05/19, 19:44

    not possible