Review main Merged

60789[BUGFIX] Respect argument showLabel in AbstractButtonViewHelper

Georg Ringer CR +2 V +2 Easy +1 −0 updated 05/22/19, 06:36

Commit message

The argument `showLabel` must be used while creating a button.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Josef Glatz +1
    • Markus Klein +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Josef Glatz +1
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Georg Ringer uploaded patch set 1 05/21/19, 17:34

  2. Georg Ringer commented on patch set 1 05/21/19, 17:35

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 05/21/19, 17:47 Completed build in 12m 27s on Tue, 21 May, 07:47 PM Test Summary: 46397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33962

  4. Markus Klein voted on patch set 1 V +1 CR +1 05/21/19, 20:07

  5. Josef Glatz voted on patch set 1 CR +1 05/21/19, 20:09

  6. Josef Glatz voted on patch set 1 V +1 05/21/19, 20:10

  7. Andreas Kienast voted on patch set 1 V +2 CR +2 05/22/19, 06:36

  8. Andreas Kienast merged patch set 2 05/22/19, 06:36