60790[TASK] Move md5.js into an AMD module
Commit message
Review
-
Code review CR +2 Done
- Frank Nägler +2
- Susi Moog +1
-
Verified V +2 Done
- Frank Nägler +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 10
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Hashing/Md5.tsnew+251 −0
- Build/Sources/TypeScript/backend/Tests/Hashing/Md5Test.tsnew+26 −0
- Build/Sources/TypeScript/filelist/Resources/Public/TypeScript/ContextMenuActions.ts+5 −4
- Build/types/TYPO3/index.d.ts+0 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Hashing/Md5.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngineValidation.js+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/md5.js+1 −0
- typo3/sysext/backend/Tests/JavaScript/Hashing/Md5Test.jsnew+13 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-88432-ReplacedMd5jsWithAnAMDModule.rstnew+33 −0
- typo3/sysext/filelist/Resources/Public/JavaScript/ContextMenuActions.js+1 −1
Review log 1014
-
Andreas Kienast uploaded patch set 1 05/21/19, 20:40
-
TYPO3com voted on patch set 1 V -1 05/21/19, 20:53 Completed build in 13m 09s on Tue, 21 May, 10:53 PM Test Summary: 1 of 46738 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33963
-
Andreas Kienast uploaded patch set 2 05/22/19, 18:47
-
Andreas Kienast uploaded patch set 3 05/22/19, 18:48
-
TYPO3com voted on patch set 2 V +1 05/22/19, 19:02 Completed build in 15m 15s on Wed, 22 May, 09:02 PM Test Summary: 46389 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33970
-
TYPO3com voted on patch set 3 V +1 05/22/19, 19:04 Completed build in 15m 17s on Wed, 22 May, 09:04 PM Test Summary: 46390 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33971
-
Andreas Kienast uploaded patch set 4 05/24/19, 11:21
-
Andreas Kienast uploaded patch set 5 05/24/19, 11:23
-
TYPO3com voted on patch set 5 V +1 05/24/19, 11:36 Completed build in 13m 03s on Fri, 24 May, 01:36 PM Test Summary: 46450 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34008
-
Susi Moog voted on patch set 5 V +1 CR +1 05/24/19, 12:34
-
Frank Nägler voted on patch set 5 V +2 CR +2 05/24/19, 13:22
-
Frank Nägler merged patch set 6 05/24/19, 13:22
-
Oliver Hader commented on patch set 6 05/29/19, 12:43
Shouldn't the original source be mentioned somewhere? http://www.webtoolkit.info/javascript_md5.html What were the benefits of transforming that to TypeScript instead of using a package like https://www.npmjs.com/package/md5.js? -
Andreas Kienast commented on patch set 6 05/29/19, 13:38
> Patch Set 6: > > Shouldn't the original source be mentioned somewhere? > http://www.webtoolkit.info/javascript_md5.html True, I didn't spot that this is not a TYPO3 licence header. > What were the benefits of transforming that to TypeScript instead of using a package like https://www.npmjs.com/package/md5.js? I wanted to have a dedicated module with enabling clean dependency management. We refrained from introducing another dependency from npm, but I think we can discuss this again (and then update the RST file).