Review main Merged

60790[TASK] Move md5.js into an AMD module

Andreas Kienast CR +2 V +2 Hard +345 −8 updated 05/29/19, 13:38

Commit message

The file `md5.js` used to generate a MD5 hash in JavaScript is deprecated
and replaced by an AMD module `TYPO3/CMS/Backend/Hashing/Md5`.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Susi Moog +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 1014

  1. Andreas Kienast uploaded patch set 1 05/21/19, 20:40

  2. TYPO3com voted on patch set 1 V -1 05/21/19, 20:53 Completed build in 13m 09s on Tue, 21 May, 10:53 PM Test Summary: 1 of 46738 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33963

  3. Andreas Kienast uploaded patch set 2 05/22/19, 18:47

  4. Andreas Kienast uploaded patch set 3 05/22/19, 18:48

  5. TYPO3com voted on patch set 2 V +1 05/22/19, 19:02 Completed build in 15m 15s on Wed, 22 May, 09:02 PM Test Summary: 46389 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33970

  6. TYPO3com voted on patch set 3 V +1 05/22/19, 19:04 Completed build in 15m 17s on Wed, 22 May, 09:04 PM Test Summary: 46390 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33971

  7. Andreas Kienast uploaded patch set 4 05/24/19, 11:21

  8. Andreas Kienast uploaded patch set 5 05/24/19, 11:23

  9. TYPO3com voted on patch set 5 V +1 05/24/19, 11:36 Completed build in 13m 03s on Fri, 24 May, 01:36 PM Test Summary: 46450 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34008

  10. Susi Moog voted on patch set 5 V +1 CR +1 05/24/19, 12:34

  11. Frank Nägler voted on patch set 5 V +2 CR +2 05/24/19, 13:22

  12. Frank Nägler merged patch set 6 05/24/19, 13:22

  13. Oliver Hader commented on patch set 6 05/29/19, 12:43

    Shouldn't the original source be mentioned somewhere? http://www.webtoolkit.info/javascript_md5.html What were the benefits of transforming that to TypeScript instead of using a package like https://www.npmjs.com/package/md5.js?
  14. Andreas Kienast commented on patch set 6 05/29/19, 13:38

    > Patch Set 6: > > Shouldn't the original source be mentioned somewhere? > http://www.webtoolkit.info/javascript_md5.html True, I didn't spot that this is not a TYPO3 licence header. > What were the benefits of transforming that to TypeScript instead of using a package like https://www.npmjs.com/package/md5.js? I wanted to have a dedicated module with enabling clean dependency management. We refrained from introducing another dependency from npm, but I think we can discuss this again (and then update the RST file).