Review main Merged Breaking

60791[!!!][TASK] Remove TBE_EDITOR.typo3form

Andreas Kienast CR +2 V +2 Normal +33 −57 updated 05/24/19, 07:16

Commit message

This patch removes the TBE_EDITOR.typo3form object, which is unused for
a long time now. This "API" was used to either get or set values of
form fields in a very old iteration of the FormEngine.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Tymoteusz Motylewski +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 810

  1. Andreas Kienast uploaded patch set 1 05/21/19, 20:51

  2. Andreas Kienast updated the commit message in patch set 2 05/21/19, 20:59

  3. TYPO3com voted on patch set 1 V +1 05/21/19, 21:07 Completed build in 15m 49s on Tue, 21 May, 11:07 PM Test Summary: 46397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33964

  4. TYPO3com voted on patch set 2 V +1 05/21/19, 21:13 Completed build in 14m 06s on Tue, 21 May, 11:13 PM Test Summary: 46397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33966

  5. Georg Ringer voted on patch set 2 V +1 CR +1 05/22/19, 06:07

  6. Tymoteusz Motylewski voted on patch set 2 CR +1 05/23/19, 20:19

  7. Oliver Klee voted on patch set 2 CR +1 05/23/19, 21:31

  8. Mathias Brodala commented on patch set 2 V +1 CR +1 05/24/19, 07:15

    Verified by searching for usage in the TYPO3 source.
  9. Andreas Kienast voted on patch set 2 V +2 CR +2 05/24/19, 07:15

  10. Andreas Kienast merged patch set 3 05/24/19, 07:16