Review main Abandoned

60801[BUGFIX] Provide flagIdentifier property in LanguageMenuProcessor

Alexander Stehlik CR 0 V 0 Easy +11 −0 updated 05/29/19, 06:28

Commit message

The LanguageMenuProcessor now adds the flagIdentifier property
of language records to the result array.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 56

  1. Alexander Stehlik uploaded patch set 1 05/23/19, 08:35

  2. Mathias Brodala commented on patch set 1 V -1 05/23/19, 08:41

    I don't think we should promote the bad practice to use flags for languages.
  3. TYPO3com voted on patch set 1 V +1 05/23/19, 08:49 Completed build in 13m 38s on Thu, 23 May, 10:49 AM Test Summary: 46389 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33978

  4. Richard Haeser commented on patch set 1 05/29/19, 06:16

    A flag is not a language indeed so I totally get the point of Mathias. Although, if we don't want flags for languages, we shouldn't do that in backend as well. Beside that, I think most visitors are used to switch languages by using a flag. So in my opinion the usage of flags is ok.
  5. Richard Haeser commented on patch set 1 05/29/19, 06:17

    If we will start the process of removing flags in backend as well, we can abandon this change as well.
  6. Alexander Stehlik abandoned the change 05/29/19, 06:28

    hreflang can be used for language / country combinations if needed. If access to flagIdentifier is really required you can easily do this with an extension of the LanguageMenuProcessor.