Review main Merged

60802[BUGFIX] Fix syntax and logic errors in BE Fluid templates

Claus Due CR +2 V +2 Normal +28 −31 updated 06/29/19, 11:20

Commit message

Fixes an invalid syntax occurrence in the "PageZero.html"
template from EXT:tstemplate. And fixes a logical error
plus incorrect XML tag nesting in the partial template
"DocHeader.html" from EXT:backend.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Jonas Eberle +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Jonas Eberle +1
    • Guido Schmechel +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1924

  1. Claus Due uploaded patch set 1 05/23/19, 10:48

  2. Claus Due uploaded patch set 2 05/23/19, 10:49

  3. Claus Due commented on patch set 2 05/23/19, 10:53

    DocHeader.html:19

    This is the case that was unreachable: due to the two conditions, in the inner condition the menu will always be non-emtpy and the "else" will not trigger. Therefore the CSS class "module-docheader-bar-column-left col-xs-12 text-right" from the outermost "else" clause is set as default CSS class - and this is then overwritten with a new CSS class if the menu is non-empty.
  4. TYPO3com voted on patch set 1 V -1 05/23/19, 11:03 Completed build in 15m 00s on Thu, 23 May, 01:03 PM Test Summary: 46389 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33979

  5. TYPO3com voted on patch set 2 V +1 05/23/19, 11:04 Completed build in 14m 28s on Thu, 23 May, 01:04 PM Test Summary: 46389 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33980

  6. Jonas Eberle commented on patch set 2 CR +1 05/23/19, 15:27

    Thank you for simplifying and improving the shipped Fluid templates. Looks a lot better to me.
  7. Georg Ringer commented on patch set 2 CR -1 05/23/19, 20:02

    Unresolved

    please change to Resolves:
  8. Oliver Klee updated the commit message in patch set 3 05/23/19, 21:31

  9. TYPO3com voted on patch set 3 V +1 05/23/19, 21:45 Completed build in 13m 40s on Thu, 23 May, 11:45 PM Test Summary: 46389 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33986

  10. Jonas Eberle voted on patch set 3 V +1 CR +1 06/12/19, 21:44

  11. Jan Stockfisch voted on patch set 3 CR +1 06/13/19, 06:57

  12. Daniel Goerz uploaded patch set 4 06/28/19, 11:26

  13. Daniel Goerz commented on patch set 4 V +1 CR +1 06/28/19, 11:27

    Had to change the DocHeader partial to keep the Fix from https://review.typo3.org/c/Packages/TYPO3.CMS/+/60368 valid
  14. TYPO3com voted on patch set 4 V +1 06/28/19, 11:37 Completed build in 11m 18s on Fri, 28 Jun, 01:37 PM Test Summary: 46517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34606

  15. Guido Schmechel commented on patch set 4 06/28/19, 15:47

    DocHeader.html:6

    Do we need spaces? Like in the other file?
  16. Daniel Goerz commented on patch set 5 06/28/19, 15:52

    Published edit on patch set 4.
  17. Daniel Goerz commented on patch set 5 06/28/19, 15:52

    DocHeader.html:6 Reply

    Done
  18. Daniel Goerz voted on patch set 5 V +1 CR +1 06/28/19, 15:52

  19. TYPO3com voted on patch set 5 V +1 06/28/19, 16:08 Completed build in 15m 33s on Fri, 28 Jun, 06:08 PM Test Summary: 46826 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34624

  20. Jonas Eberle voted on patch set 5 V +1 CR +1 06/28/19, 18:00

  21. Guido Schmechel voted on patch set 5 V +1 CR +1 06/29/19, 10:38

  22. Daniel Goerz voted on patch set 5 V +2 CR +2 06/29/19, 11:08

  23. Daniel Goerz merged patch set 6 06/29/19, 11:09

  24. Daniel Goerz commented on patch set 6 06/29/19, 11:20